[HOLD for payment 2022-12-08] Manually connecting a bank account is broken

[pecanoro]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Add a new workspace
2. Navigate to Settings > [Workspace] > Connect bank account > Connect manually.
3. Select "Manually enter account details" and enter random numbers for the bank account numbers (Enter a valid routing number or validation will fail)
4. Select "Save & Continue"
5. Fill company step form.
6. Select "Save & Continue"

Expected Result:

7. Get asked to double-check the information. Select "Save & Continue" again should move to Personal Info step

Actual Result:

8. Error “The routing and account number cannot be the same. Please verify the information that you entered.” is shown and it's impossible to move beyond the message.

Workaround:

No workaround.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: v1.2.33-1
Reproducible in staging?: no
Reproducible in production?: no
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: Myself
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1669755030195659

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @davidcardoza (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[pecanoro]

This is the PR that caused the regression: #13076 cc/ @sketchydroide @luacmartins @mananjadhav @ravindra-encoresky

[Luke9389]

Have we tried using 123456789 as the TaxID number? @neil-marcellini mentioned here that this was now required.

[Luke9389]

Took the deploy blocker label off of this issue bc it's not on staging or prod. The PR linked above does fix the issue, but won't be CP'ed and is instead going to be deployed along with the offending PR.

[mananjadhav]

Thanks @luacmartins for the help here! Apologies for the issue!

[pecanoro]

@Luke9389 it is a deploy blocker, it doesn't have to be broken on staging to hold the deploy. If deploying normally is going to break the flow on staging, we need to hold until a fix is merged. Why would you wait until the code is deployed to actually add the label? Either way, now that Carlos fixed it, it is ok to leave the deploy blocker label off.

@luacmartins Thanks for the quick fix!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add reimbursement account draft #13167

If no regressions arise, payment will be issued on 2022-12-08. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins / @Luke9389] The PR that introduced the bug has been identified. Link to the PR: [HOLD for payment 2022-12-08] [$250][Form Refactor] CompanyStep #9580
• [@luacmartins / @Luke9389] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Refactor companystep to use Form -2 #13076 (comment)
• [@luacmartins / @Luke9389] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: N/A

[davidcardoza]

Is there a contributor I should be paying for this job?

[luacmartins]

@davidcardoza np! Rocio identified the issue and it was fixed internally.