[HOLD for payment 2023-02-08] Chat - Concierge chat links opening in OldDot

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #12376

Action Performed:

1. Create a brand new account
2. Create a workspace
3. Go to the concierge chat and click the link for chatting with the setup specialist

Expected Result:

Verify that the #admin room is opened in the same tab

Actual Result:

Taking user to OldDot

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• Desktop App
• Mobile Web

Version Number: 1.2.25.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5813649_12376.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[muttmuure]

@kbecciv I'm not sure I know what 1. Create a brand new account means - do you mean a unique domain?

[kbecciv]

@muttmuure No, you can create regular public account.

[melvin-bot]

@kbecciv Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

I can't reproduce:

2022-11-22_14-02-44.mp4

[muttmuure]

Please feel free to reassign or clarify the exact steps!

[jasperhuangg]

@kbecciv if you sign in with the Olddot sign in portal afterwards it actually navigates you to NewDot:

not.a.bug.mov

Closing

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.63-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix linking to report for staging URLs #14487

If no regressions arise, payment will be issued on 2023-02-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue (fixed internally, no need)
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jasperhuangg] The PR that introduced the bug has been identified. Link to the PR:
• [@jasperhuangg] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jasperhuangg] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jasperhuangg] Propose regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Santhosh-Sellavel]

@jasperhuangg Assign me this one, please!

bump! also assign a bz here!

[jasperhuangg]

@muttmuure Assigning you since you were the original BZ member on this (I believe)

[jasperhuangg]

Assigning @Santhosh-Sellavel since he was the C+ member who helped me debug and review my PR!

[muttmuure]

I didn't realize this was reproducible and fixed. I'll issue payment this week

[Santhosh-Sellavel]

@muttmuure payment It's due last week.

[muttmuure]

Upwork is showing an error when I try to create a job for payment:

You have already posted this draft job. Error [799613795bd63868-LHR, 799613795bd63868-LHR]

Going to try again later.

[muttmuure]

Still seeing the error message. Posted about it here: https://expensify.slack.com/archives/C01SKUP7QR0/p1676543857805809

[muttmuure]

@Santhosh-Sellavel the job listing is here: https://www.upwork.com/jobs/~01dd7b52b0c3b37962

[Santhosh-Sellavel]

Thanks applied now!

[muttmuure]

Rehired - when you've accepted I can get you paid + bonus

[Santhosh-Sellavel]

Accepted @muttmuure, not sure why bonus here?

[MelvinBot]

@jasperhuangg, @muttmuure, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

Oh yes - you're right. I typically review for bonuses when I'm paying.

This has been paid so we're all set. Thanks @Santhosh-Sellavel!