Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: All contacts disappear from LHN on adding a user to workspace reported by @thesahindia #12067

Closed
kavimuru opened this issue Oct 21, 2022 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to settings
  2. Open a workspace > Manage members
  3. Click on Invite > Select a contact and invite
  4. Check the LHN

Expected Result:

The contacts shouldn't disappear

Actual Result:

The contacts disappear

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.18-5
Reproducible in staging?: y
Reproducible in production?: No (This is inconsistent tester was able to reproduce in Production when logged this issue #12020)
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Contributor was able to reproduce in Web, but not our team. It seems inconsistent. Please double check if its not repro in production

Screen.Recording.2022-10-22.at.12.59.30.AM.mov
Record_2022-10-21-23-50-28.mp4

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666380873125949

View all open jobs on GitHub

@kavimuru kavimuru added Engineering Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2022

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Oct 21, 2022
@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Oct 21, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@chiragsalian
Copy link
Contributor

I was not able to reproduce it on staging or production. Can you retest @kavimuru or @thesahindia? I feel like if we cannot consistently reproduce it should not be a deploy blocker and should instead just be an issue to investigate.

@chiragsalian
Copy link
Contributor

Also looks like luke is OOO so i'll take over this issue from him.

@thesahindia
Copy link
Member

I am still able to consistently reproduce this with multiple accounts. Can you try this with my account?

Here's the details
Email: [email protected]
Password: Expensi99

@chiragsalian
Copy link
Contributor

Odd, i am able to get it consistently on your account. On your account, i get the issue only on staging and not on production. Very weird.

@kavimuru
Copy link
Author

@chiragsalian Our team can reproduce only in Android not in Web, mWeb and iOS

Record_2022-10-24-21-37-54_4f9154176b47c00da84e32064abf1c48.mp4

@chiragsalian chiragsalian mentioned this issue Oct 24, 2022
92 tasks
@melvin-bot melvin-bot bot closed this as completed Oct 24, 2022
@chiragsalian
Copy link
Contributor

chiragsalian commented Oct 24, 2022

Shall retest once the code hits staging. We think we found the problem.

@chiragsalian
Copy link
Contributor

Looks like the issue is resolved in 1.2.18-10. I tested on sahil's account and could not reproduce the problem.

@thesahindia or @kavimuru, can you guys retest as well?

@mallenexpensify mallenexpensify added Daily KSv2 and removed Hourly KSv2 labels Oct 24, 2022
@mallenexpensify mallenexpensify self-assigned this Oct 24, 2022
@mallenexpensify
Copy link
Contributor

@thesahindia please accept the job offer here for $250 payment for reporting https://www.upwork.com/jobs/~014351831b357edb55

Comment on this issue once you have and I'll pay

@chiragsalian chiragsalian removed the DeployBlockerCash This issue or pull request should block deployment label Oct 24, 2022
@chiragsalian
Copy link
Contributor

Retested and it LGTM, i'm moving forward with deploy. Keeping this issue open for payment.

@thesahindia
Copy link
Member

Comment on this issue once you have and I'll pay

Accepted. Thanks!

@mallenexpensify
Copy link
Contributor

Paid @thesahindia , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants