[HOLD for payment 2022-11-16] [$250] Bug: [Staging] On add Paypal page, the add Paypal button isn't working correctly reported by @Tushu17

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open Web/mWeb staging.new.expensify
2. Go to settings > Payments > Add Paypal page
3. Write invalid Paypal name and click add Paypal button.
4. Empty input field.

Expected Result:

Button should be disabled if input field is empty

Actual Result:

Button doesn't get disabled.

Workaround:

unknown

Platform:

Where is this issue occurring?

• - Web
• - iOS
• - Android
• - Desktop App
• - Mobile Web

Version Number: 1.2.18-4
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2022-10-20.at.10.06.45.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666284006608739

View all open jobs on GitHub

Recording.750.mp4

[Tushu17]

Proposal

We just need to change:-

App/src/pages/settings/Payments/AddPayPalMePage.js

Line 103 in 1bca7a4

isDisabled={this.state.payPalMeUsername === this.props.payPalMeData.description}

with

isDisabled={this.state.payPalMeUsername === this.props.payPalMeData.description || !this.state.payPalMeUsername.length}

[Puneet-here]

Proposal

The button will be enabled if user uses empty space so we need to check if a value exists by using _.isEmpty(this.state.payPalMeUsername.trim())
I believe we can also remove the current check since the user don't have any option to edit username unless they visit this page by url

App/src/pages/settings/Payments/AddPayPalMePage.js

Line 103 in 07fc7d7

isDisabled={this.state.payPalMeUsername === this.props.payPalMeData.description}

So we can use _.isEmpty(this.state.payPalMeUsername.trim()) only or add it in the current logic like this

isDisabled={(this.state.payPalMeUsername === this.props.payPalMeData.description) || `_.isEmpty(this.state.payPalMeUsername.trim())`} 

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[mallenexpensify]

@sophiepintoraetz new BZ chore SO is here, we want to ensure BZ stays assigned to all issues so we can get to BugZero,

[melvin-bot]

@sophiepintoraetz Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@sophiepintoraetz Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sophiepintoraetz]

@kavimuru - please make sure you're filling out this section here in your issues and that this is occurring on staging.

[sophiepintoraetz]

Also, I am able to replicate the issue on web and iOS so sending over to engineering.

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Current assignee @pecanoro is eligible for the External assigner, not assigning anyone new.

[Santhosh-Sellavel]

@michaelhaxhiu Requested changes yesterday. The Recent changes had been done 10 hours ago. Waiting for my review will get to it tomorrow!

[Santhosh-Sellavel]

@Puneet-here Please post a message once the requested changes are done, not sure if is this ready for review again.

[michaelhaxhiu]

Excellent! I'll leave it to you all + @pecanoro from here to help move it forward.

[Puneet-here]

@Puneet-here Please post a message once the requested changes are done, not sure if is this ready for review again.

It's ready.

[melvin-bot]

@pecanoro, @sophiepintoraetz, @Santhosh-Sellavel, @Puneet-here Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Santhosh-Sellavel]

Not overdue PR is waiting for review from @pecanoro

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

• A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here: (questioning here
• The PR that introduced the bug has been identified. Link to the PR here
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment here
• A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion here
• Payment has been made to the issue reporter (if applicable)
• Payment has been made to the contributor that fixed the issue (if applicable)
• Payment has been made to the contributor+ that helped on the issue (if applicable)

[sophiepintoraetz]

@Santhosh-Sellavel - would you mind answering the following please:

• The PR that introduced the bug has been identified. Link to the PR:

[Santhosh-Sellavel]

Technically this PR #6545 should have added the check for empty case check too, this is where isDisabled was introduced on that page!

cc: @sophiepintoraetz @pecanoro

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.25-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: On add Paypal page, the add Paypal button isn't working correctly  #12197

If no regressions arise, payment will be issued on 2022-11-16. 🎊

[sophiepintoraetz]

@Tushu17 and @Santhosh-Sellavel - can you please apply for the Job posted! Then we can close this one out! (@Puneet-here - you're all set)

[sophiepintoraetz]

Bump @Santhosh-Sellavel (offer is in your inbox, @Tushu17!)

[sophiepintoraetz]

All right - closing the issue coz payment is done! @Santhosh-Sellavel - feel free to reach out to me and/or respond to the offer in Upwork.

[Santhosh-Sellavel]

@sophiepintoraetz I didn't receive any offer from you, I got couple of offers issue but not received for this.

[sophiepintoraetz]

@Santhosh-Sellavel - apologies! I could have sworn I did but anyways, here we are

[Santhosh-Sellavel]

@sophiepintoraetz You could hire me straight away as you have an option to do so.

I get it you might have invited me earlier too. Only when you hire me I will receive an offer, which will show up on messages.

[Santhosh-Sellavel]

Applied for the job now!