Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2022-10-31] Software keyboard hides when you scroll the chat #11915

Closed
roryabraham opened this issue Oct 17, 2022 · 12 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@roryabraham
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open a chat
  2. Click on the compose input to open the keyboard
  3. Scroll the chat

Expected Result:

The keyboard should stay open.

Actual Result:

The keyboard closes.

Workaround:

None, this is a pain point for users and a critical regression.

Platform:

Where is this issue occurring?

  • iOS
  • Android
  • Mobile Web

Version Number: 1.2.16-4
Reproducible in staging?: yes
Reproducible in production?: yes
Email or phone of affected tester (no customers): n/a
Issue reported by: (I don't know their GH name)
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665991322162069

View all open jobs on GitHub

@roryabraham roryabraham added Engineering Improvement Item broken or needs improvement. Hourly KSv2 labels Oct 17, 2022
@roryabraham roryabraham self-assigned this Oct 17, 2022
@parasharrajat
Copy link
Member

Previously, we added this so that the user is able to see the whole list instead of a few items.

So the thought was that if a user is trying to scroll the list, the user probably wants to see the items below the keyboard. This kind of helped on small screens.

@roryabraham
Copy link
Contributor Author

Working on this ... currently blocked by infra process here. Once that's done hopefully we can push this forward quickly

@roryabraham
Copy link
Contributor Author

@roryabraham
Copy link
Contributor Author

WIP PR: #11944

@roryabraham
Copy link
Contributor Author

PR ready for review. I'm choosing not to CP it so that it gets to undergo a full regression suite.

@roryabraham roryabraham added the Reviewing Has a PR in review label Oct 18, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot closed this as completed Oct 21, 2022
@mountiny mountiny added Daily KSv2 and removed Hourly KSv2 labels Oct 24, 2022
@mountiny mountiny changed the title Software keyboard hides when you scroll the chat [HOLD for payment 2022-10-31] Software keyboard hides when you scroll the chat Oct 24, 2022
@mountiny
Copy link
Contributor

@mountiny mountiny reopened this Oct 24, 2022
@mountiny mountiny added Weekly KSv2 Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Oct 24, 2022
@mountiny
Copy link
Contributor

Assigning @dylanexpensify who kindly agreed to help out with paying out this bonus to @aimane-chnaif in weeks time

@aimane-chnaif
Copy link
Contributor

Thanks @mountiny @dylanexpensify

@dylanexpensify
Copy link
Contributor

@aimane-chnaif here's the job post for you to apply!

@aimane-chnaif
Copy link
Contributor

@dylanexpensify applied

@dylanexpensify
Copy link
Contributor

Offer sent @aimane-chnaif !

@dylanexpensify
Copy link
Contributor

Payment sent, contract ended, posting closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants