Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold for Payment 23 Sept] Attachment is displayed blank after uploading Issue reported by: @varshamb #11044

Closed
kbecciv opened this issue Sep 16, 2022 · 21 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Sep 16, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensifail.com
  2. Log in with any account
  3. Select any user and click on plus button
  4. Select Add Attachment
  5. Pick any attachment and click Send

Expected Result:

Attachment is not displayed blank after uploading

Actual Result:

Attachment is displayed blank after uploading

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • Mobile Web

Version Number: 1.2.1.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1136.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause- Internal Team/@varshamb

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663232936099099

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Sep 16, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 16, 2022

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@varshamb
Copy link
Contributor

Yesterday this was reported by me on Slack.

https://expensify.slack.com/archives/C01GTK53T8Q/p1663232936099099

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Sep 16, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 16, 2022

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@mountiny
Copy link
Contributor

Adding External label @laurenreidexpensify to make sure we will pay out @varshamb for reporting this regression.

@mountiny
Copy link
Contributor

Cannot reproduce locally but getting following errors in console
Screenshot 2022-09-16 at 11 05 37

@mountiny
Copy link
Contributor

Works in production, this must be related to the staging api servers and some settings we need to update there as well to be able to process images.

@laurenreidexpensify laurenreidexpensify changed the title Attachment - Attachment is displayed blank after uploading Attachment - Attachment is displayed blank after uploading Issue reported by: @varshamb Sep 16, 2022
@laurenreidexpensify laurenreidexpensify changed the title Attachment - Attachment is displayed blank after uploading Issue reported by: @varshamb Attachment is displayed blank after uploading Issue reported by: @varshamb Sep 16, 2022
@laurenreidexpensify
Copy link
Contributor

@mountiny mountiny added the Reviewing Has a PR in review label Sep 16, 2022
@mountiny mountiny assigned mountiny and unassigned marcaaron Sep 16, 2022
@mountiny
Copy link
Contributor

Reopening this for now to wait until the server changes are deployed and we can confirm the change worked

@mountiny mountiny reopened this Sep 16, 2022
@mountiny
Copy link
Contributor

image

Confirmed in staging this is fixed!

@varshamb
Copy link
Contributor

@laurenreidexpensify Can you please reopen the issue and send the correct upworks link. Thank you.

@laurenreidexpensify
Copy link
Contributor

@varshamb invited to job!

@laurenreidexpensify laurenreidexpensify added Weekly KSv2 and removed Hourly KSv2 labels Sep 16, 2022
@laurenreidexpensify laurenreidexpensify changed the title Attachment is displayed blank after uploading Issue reported by: @varshamb [Hold for Payment 23 Sept] Attachment is displayed blank after uploading Issue reported by: @varshamb Sep 16, 2022
@mountiny
Copy link
Contributor

@laurenreidexpensify I think since this was reported as valid bug - deploy blocker even - there does not need to be a regression period included for the payment. I think we can pay @varshamb as soon as you get a chance.

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@luacmartins
Copy link
Contributor

Issue not reproducible anymore, removing the DeployBlocker label

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Sep 20, 2022
@laurenreidexpensify laurenreidexpensify added Daily KSv2 and removed Weekly KSv2 labels Sep 22, 2022
@laurenreidexpensify
Copy link
Contributor

@varshamb The hire offer is pending in Upwork - I can issue payment as soon as you accept :) Thanks!

@varshamb
Copy link
Contributor

@laurenreidexpensify Applied on 16Sep, Please resend hire offer if needed.

@laurenreidexpensify
Copy link
Contributor

@varshamb oh weird, it's showing on my side on Upwork that you still need to accept the offer. Can you take a look and doublecheck nothing is pending there on your account? Thanks!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@varshamb
Copy link
Contributor

@laurenreidexpensify Accepted the offer.

@laurenreidexpensify
Copy link
Contributor

Payment issued Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

8 participants