From f8f848e84f0d9dfb2c52f6ec6fe24f52e69ed6ca Mon Sep 17 00:00:00 2001 From: Prince Mendiratta Date: Tue, 28 Mar 2023 00:24:40 +0530 Subject: [PATCH] reorganize accessibility translation keys Signed-off-by: Prince Mendiratta --- src/languages/en.js | 6 +++--- src/languages/es.js | 6 +++--- src/pages/home/report/ReportActionsList.js | 2 +- src/pages/home/sidebar/SidebarLinks.js | 2 +- src/pages/signin/LoginForm.js | 2 +- tests/ui/UnreadIndicatorsTest.js | 8 ++++---- 6 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/languages/en.js b/src/languages/en.js index c2bf5fe6b4ae..6bed9dd108fb 100755 --- a/src/languages/en.js +++ b/src/languages/en.js @@ -276,6 +276,8 @@ export default { fabNewChat: 'New chat (Floating action)', chatPinned: 'Chat pinned', draftedMessage: 'Drafted message', + listOfChatMessages: 'List of chat messages', + listOfChats: 'List of chats', }, iou: { amount: 'Amount', @@ -608,6 +610,7 @@ export default { invalidFormatEmailLogin: 'The email entered is invalid. Please fix the format and try again.', }, cannotGetAccountDetails: 'Couldn\'t retrieve account details, please try to sign in again.', + loginForm: 'Login form', }, personalDetails: { error: { @@ -1205,14 +1208,11 @@ export default { allCountries: CONST.ALL_COUNTRIES, accessibilityHints: { navigateToChatsList: 'Navigate back to chats list', - listOfChatMessages: 'List of chat messages', chatWelcomeMessage: 'Chat welcome message', navigatesToChat: 'Navigates to a chat', newMessageLineIndicator: 'New message line indicator', chatMessage: 'Chat message', lastChatMessagePreview: 'Last chat message preview', - loginForm: 'Login form', - listOfChats: 'List of chats', workspaceName: 'Workspace name', chatUserDisplayNames: 'Chat user display names', scrollToNewestMessages: 'Scroll to newest messages', diff --git a/src/languages/es.js b/src/languages/es.js index 6f6210b89f41..f8173c43aee7 100644 --- a/src/languages/es.js +++ b/src/languages/es.js @@ -275,6 +275,8 @@ export default { fabNewChat: 'Nuevo chat', chatPinned: 'Chat fijado', draftedMessage: 'Mensaje borrador', + listOfChatMessages: 'Lista de mensajes del chat', + listOfChats: 'lista de chats', }, iou: { amount: 'Importe', @@ -607,6 +609,7 @@ export default { invalidFormatEmailLogin: 'El email introducido no es válido. Corrígelo e inténtalo de nuevo.', }, cannotGetAccountDetails: 'No se pudieron cargar los detalles de tu cuenta, por favor intenta iniciar sesión de nuevo.', + loginForm: 'Formulario de inicio de sesión', }, personalDetails: { error: { @@ -1671,14 +1674,11 @@ export default { }, accessibilityHints: { navigateToChatsList: 'Vuelve a la lista de chats', - listOfChatMessages: 'Lista de mensajes del chat', chatWelcomeMessage: 'Mensaje de bienvenida al chat', navigatesToChat: 'Navega a un chat', newMessageLineIndicator: 'Indicador de nueva línea de mensaje', chatMessage: 'mensaje de chat', lastChatMessagePreview: 'Vista previa del último mensaje del chat', - loginForm: 'Formulario de inicio de sesión', - listOfChats: 'lista de chats', workspaceName: 'Nombre del espacio de trabajo', chatUserDisplayNames: 'Nombres de los usuarios del chat', scrollToNewestMessages: 'Desplázate a los mensajes más recientes', diff --git a/src/pages/home/report/ReportActionsList.js b/src/pages/home/report/ReportActionsList.js index 5a96f36de4a7..2e02a794ed03 100644 --- a/src/pages/home/report/ReportActionsList.js +++ b/src/pages/home/report/ReportActionsList.js @@ -151,7 +151,7 @@ class ReportActionsList extends React.Component { return ( - + this.input = el} label={this.props.translate('loginForm.phoneOrEmail')} diff --git a/tests/ui/UnreadIndicatorsTest.js b/tests/ui/UnreadIndicatorsTest.js index 6b8430f952b7..ad2d622a4315 100644 --- a/tests/ui/UnreadIndicatorsTest.js +++ b/tests/ui/UnreadIndicatorsTest.js @@ -52,7 +52,7 @@ beforeAll(() => { }); function scrollUpToRevealNewMessagesBadge() { - const hintText = Localize.translateLocal('accessibilityHints.listOfChatMessages'); + const hintText = Localize.translateLocal('sidebarScreen.listOfChatMessages'); fireEvent.scroll(screen.queryByLabelText(hintText), { nativeEvent: { contentOffset: { @@ -106,7 +106,7 @@ function navigateToSidebarOption(index) { * @return {Boolean} */ function isDrawerOpen() { - const hintText = Localize.translateLocal('accessibilityHints.listOfChats'); + const hintText = Localize.translateLocal('sidebarScreen.listOfChats'); const sidebarLinks = screen.queryAllByLabelText(hintText); return !lodashGet(sidebarLinks, [0, 'props', 'accessibilityElementsHidden']); } @@ -132,7 +132,7 @@ function signInAndGetAppWithUnreadChat() { render(); return waitForPromisesToResolveWithAct() .then(() => { - const hintText = Localize.translateLocal('accessibilityHints.loginForm'); + const hintText = Localize.translateLocal('loginForm.loginForm'); const loginForm = screen.queryAllByLabelText(hintText); expect(loginForm).toHaveLength(1); @@ -208,7 +208,7 @@ describe('Unread Indicators', () => { expect(LocalNotification.showCommentNotification.mock.calls).toHaveLength(0); // Verify the sidebar links are rendered - const sidebarLinksHintText = Localize.translateLocal('accessibilityHints.listOfChats'); + const sidebarLinksHintText = Localize.translateLocal('sidebarScreen.listOfChats'); const sidebarLinks = screen.queryAllByLabelText(sidebarLinksHintText); expect(sidebarLinks).toHaveLength(1); expect(isDrawerOpen()).toBe(true);