From ede606c2f13947bf678fe9563471bb3ed5390cad Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Tue, 22 Aug 2023 17:34:43 -0600 Subject: [PATCH] Merge pull request #25726 from Expensify/aldo-fix-admin-welcome-message Fix admin post only welcome message (cherry picked from commit eaccec9ecc1136663242f06d8da65d2c0877af03) --- src/components/ReportWelcomeText.js | 22 +++++++++------------- src/libs/ReportUtils.js | 3 ++- 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/src/components/ReportWelcomeText.js b/src/components/ReportWelcomeText.js index 9fc446df31e3..80c26b5d6b3f 100644 --- a/src/components/ReportWelcomeText.js +++ b/src/components/ReportWelcomeText.js @@ -65,7 +65,6 @@ function ReportWelcomeText(props) { const isPolicyExpenseChat = ReportUtils.isPolicyExpenseChat(props.report); const isChatRoom = ReportUtils.isChatRoom(props.report); const isDefault = !(isChatRoom || isPolicyExpenseChat); - const isAdminsOnlyPostingRoom = ReportUtils.isAdminsOnlyPostingRoom(props.report); const participantAccountIDs = lodashGet(props.report, 'participantAccountIDs', []); const isMultipleParticipant = participantAccountIDs.length > 1; const displayNamesWithTooltips = ReportUtils.getDisplayNamesWithTooltips( @@ -100,19 +99,16 @@ function ReportWelcomeText(props) { {isChatRoom && ( <> {roomWelcomeMessage.phrase1} - {/* for rooms in which only admins can post we dont need room name and phrase two */} - {(!isAdminsOnlyPostingRoom || isUserPolicyAdmin) && ( - <> - Navigation.navigate(ROUTES.getReportDetailsRoute(props.report.reportID))} - suppressHighlighting - > - {ReportUtils.getReportName(props.report)} - - {roomWelcomeMessage.phrase2} - + {roomWelcomeMessage.showReportName && ( + Navigation.navigate(ROUTES.getReportDetailsRoute(props.report.reportID))} + suppressHighlighting + > + {ReportUtils.getReportName(props.report)} + )} + {roomWelcomeMessage.phrase2 !== undefined && {roomWelcomeMessage.phrase2}} )} {isDefault && ( diff --git a/src/libs/ReportUtils.js b/src/libs/ReportUtils.js index 99dd31ab99aa..f40003382121 100644 --- a/src/libs/ReportUtils.js +++ b/src/libs/ReportUtils.js @@ -766,7 +766,7 @@ function canDeleteReportAction(reportAction, reportID) { */ function getRoomWelcomeMessage(report, isUserPolicyAdmin) { - const welcomeMessage = {}; + const welcomeMessage = {showReportName: true}; const workspaceName = getPolicyName(report); if (isArchivedRoom(report)) { @@ -780,6 +780,7 @@ function getRoomWelcomeMessage(report, isUserPolicyAdmin) { welcomeMessage.phrase2 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAdminRoomPartTwo'); } else if (isAdminsOnlyPostingRoom(report) && !isUserPolicyAdmin) { welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAdminOnlyPostingRoom'); + welcomeMessage.showReportName = false; } else if (isAnnounceRoom(report)) { welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAnnounceRoomPartOne', {workspaceName}); welcomeMessage.phrase2 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAnnounceRoomPartTwo', {workspaceName});