From 9af928c44ac88035d20ea9c02e883314a352bef7 Mon Sep 17 00:00:00 2001 From: andrew Date: Thu, 2 Sep 2021 11:41:37 -0600 Subject: [PATCH 1/4] Remove echo as it won't work on the same line --- .github/workflows/platformDeploy.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/platformDeploy.yml b/.github/workflows/platformDeploy.yml index 769cdacc8f1b..8d0771437af0 100644 --- a/.github/workflows/platformDeploy.yml +++ b/.github/workflows/platformDeploy.yml @@ -243,9 +243,7 @@ jobs: - name: Set iOS version in ENV if: ${{ fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }} - run: | - echo "IOS_VERSION=$(echo '${{ github.event.release.tag_name }}' | tr '-' '.')" >> $GITHUB_ENV - echo "iOS version is: ${{ env.IOS_VERSION }}" + run: echo "IOS_VERSION=$(echo '${{ github.event.release.tag_name }}' | tr '-' '.')" >> $GITHUB_ENV - name: Run Fastlane for App Store release if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' }} From df954c6c489cd5768ffe0fe329a2266c09ec93a8 Mon Sep 17 00:00:00 2001 From: andrew Date: Thu, 2 Sep 2021 16:25:30 -0600 Subject: [PATCH 2/4] Update fastlane --- Gemfile.lock | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 3d858b089cbf..4d61b5b691a3 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -14,21 +14,21 @@ GEM json (>= 1.5.1) artifactory (3.0.15) atomos (0.1.3) - aws-eventstream (1.1.1) - aws-partitions (1.490.0) - aws-sdk-core (3.119.1) + aws-eventstream (1.2.0) + aws-partitions (1.495.0) + aws-sdk-core (3.121.0) aws-eventstream (~> 1, >= 1.0.2) aws-partitions (~> 1, >= 1.239.0) aws-sigv4 (~> 1.1) jmespath (~> 1.0) - aws-sdk-kms (1.46.0) - aws-sdk-core (~> 3, >= 3.119.0) + aws-sdk-kms (1.48.0) + aws-sdk-core (~> 3, >= 3.120.0) aws-sigv4 (~> 1.1) - aws-sdk-s3 (1.99.0) - aws-sdk-core (~> 3, >= 3.119.0) + aws-sdk-s3 (1.102.0) + aws-sdk-core (~> 3, >= 3.120.0) aws-sdk-kms (~> 1) - aws-sigv4 (~> 1.1) - aws-sigv4 (1.2.4) + aws-sigv4 (~> 1.4) + aws-sigv4 (1.4.0) aws-eventstream (~> 1, >= 1.0.2) babosa (1.0.4) claide (1.0.3) @@ -85,7 +85,7 @@ GEM ethon (0.12.0) ffi (>= 1.3.0) excon (0.85.0) - faraday (1.7.0) + faraday (1.7.1) faraday-em_http (~> 1.0) faraday-em_synchrony (~> 1.0) faraday-excon (~> 1.1) @@ -110,7 +110,7 @@ GEM faraday_middleware (1.1.0) faraday (~> 1.0) fastimage (2.2.5) - fastlane (2.192.0) + fastlane (2.193.1) CFPropertyList (>= 2.3, < 4.0.0) addressable (>= 2.8, < 3.0.0) artifactory (~> 3.0) @@ -184,13 +184,13 @@ GEM google-cloud-core (~> 1.6) googleauth (>= 0.16.2, < 2.a) mini_mime (~> 1.0) - googleauth (0.17.0) + googleauth (0.17.1) faraday (>= 0.17.3, < 2.0) jwt (>= 1.4, < 3.0) memoist (~> 0.16) multi_json (~> 1.11) os (>= 0.9, < 2.0) - signet (~> 0.14) + signet (~> 0.15) highline (2.0.3) http-cookie (1.0.4) domain_name (~> 0.5) From 4ccf1837bf256aa3663354038b14424ca2b3ec17 Mon Sep 17 00:00:00 2001 From: andrew Date: Thu, 2 Sep 2021 16:25:54 -0600 Subject: [PATCH 3/4] Fix production uploads by debugging all the flags --- fastlane/Fastfile | 35 +++++++++++++++++++++++++++++++++-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 553d4a2bf228..61d2cbb17a5e 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -140,16 +140,47 @@ platform :ios do lane :production do deliver( api_key_path: "./ios/ios-fastlane-json-key.json", + # Skip HTMl report verification + force: true, + # VERSION will be set to the full build_number e.g. '1.0.92.0' build_number: ENV["VERSION"], + # app_version needs to be set to the short version, without the last digit e.g. '1.0.92' + app_version: ENV["VERSION"].rpartition(".")[0], + # We want to submit the version for Apple to review submit_for_review: true, + # We want to release the app as soon as it's approved automatic_release: true, - skip_metadata: true, + # We need to upload metadata to upload the release notes which is required for rach new version + skip_metadata: false, + # We do not want to upload any screenshots skip_screenshots: true, + # We do not have any binary to upload as it's already in TestFlight skip_binary_upload: true, + # Reject the current build if there is one in review + reject_if_possible: true, + # We do not want to reset the ratings + reset_ratings: false, + # Precheck cannot check for in app purchases with the API key we use precheck_include_in_app_purchases: false, submission_information: { - add_id_info_uses_idfa: false + # We currently do not use idfa: https://developer.apple.com/app-store/user-privacy-and-data-use/ + add_id_info_uses_idfa: false, + # We do not need any additional compliance + export_compliance_compliance_required: false, + # We do not use any encrpytion + export_compliance_encryption_updated: false, + export_compliance_app_type: nil, + export_compliance_uses_encryption: false, + export_compliance_is_exempt: false, + export_compliance_contains_third_party_cryptography: false, + export_compliance_contains_proprietary_cryptography: false, + # We do not show any third party content + content_rights_contains_third_party_content: false + }, + release_notes: { + 'en-US' => "Improvements and bug fixes" } ) + end end From 25e637b4dab00f47aba7fb8606719ebc288a0510 Mon Sep 17 00:00:00 2001 From: andrew Date: Thu, 2 Sep 2021 16:46:26 -0600 Subject: [PATCH 4/4] Add new lines for comments --- fastlane/Fastfile | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 61d2cbb17a5e..fd43e45ccbc5 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -140,33 +140,47 @@ platform :ios do lane :production do deliver( api_key_path: "./ios/ios-fastlane-json-key.json", + # Skip HTMl report verification force: true, + # VERSION will be set to the full build_number e.g. '1.0.92.0' build_number: ENV["VERSION"], + # app_version needs to be set to the short version, without the last digit e.g. '1.0.92' app_version: ENV["VERSION"].rpartition(".")[0], + # We want to submit the version for Apple to review submit_for_review: true, + # We want to release the app as soon as it's approved automatic_release: true, + # We need to upload metadata to upload the release notes which is required for rach new version skip_metadata: false, + # We do not want to upload any screenshots skip_screenshots: true, + # We do not have any binary to upload as it's already in TestFlight skip_binary_upload: true, + # Reject the current build if there is one in review reject_if_possible: true, + # We do not want to reset the ratings reset_ratings: false, + # Precheck cannot check for in app purchases with the API key we use precheck_include_in_app_purchases: false, submission_information: { + # We currently do not use idfa: https://developer.apple.com/app-store/user-privacy-and-data-use/ add_id_info_uses_idfa: false, + # We do not need any additional compliance export_compliance_compliance_required: false, + # We do not use any encrpytion export_compliance_encryption_updated: false, export_compliance_app_type: nil, @@ -174,6 +188,7 @@ platform :ios do export_compliance_is_exempt: false, export_compliance_contains_third_party_cryptography: false, export_compliance_contains_proprietary_cryptography: false, + # We do not show any third party content content_rights_contains_third_party_content: false },