Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response body is truncated #19

Open
jonapgar opened this issue Jun 15, 2020 · 4 comments
Open

Response body is truncated #19

jonapgar opened this issue Jun 15, 2020 · 4 comments

Comments

@jonapgar
Copy link

jonapgar commented Jun 15, 2020

Some response bodies are truncated when using saveResponse option.

This is due to the fact that you are not waiting for Network.loadingFinished

See:
ChromeDevTools/devtools-protocol#44 (comment)

@ericmustin
Copy link

just ➕ this issue and pr

@Everettss any thoughts on the associated PR here?

fwiw this helps unblock uses cases which want to use the saveResponse option on larger response bodies (like, say, uncompressed html).

@frontendphil
Copy link

Hey there! Since this functionality is important for us we've started maintaining this package over at https://github.com/auteon/puppeteer-har. The API has changed slightly and the whole thing is written in TypeScript now.

@0xThiebaut
Copy link

Hi @frontendphil thanks for the fix! Do you intend on maintaining that and enabling GitHub issues?

@ZebTheWizard
Copy link

Hey there! Since this functionality is important for us we've started maintaining this package over at https://github.com/auteon/puppeteer-har. The API has changed slightly and the whole thing is written in TypeScript now.

Sorry, but your fork is not usable and is trying to install a bunch of git hooks into my repo. Can you publish on NPM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants