Fix sub rows from overwriting the model cache of the parent #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modified line appears to be using the parent ID to recursively write each sub row into the model cache, overwriting the parent and possibly some of the sub rows. This in itself doesn't cause any issues, but if you try to use remove() on the parent ID after expanding a child row, instead of removing the parent (and all children) from the table, it removes the last item in the table, because the get() call in remove() will always return -1 from its indexOf() check - thus, causing a negative slice from the items array. Using the same reference as the indexById return the line below resolves the problem.