Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action-menu, input-number] Restore unstable tests #9784

Open
jcfranco opened this issue Jul 15, 2024 · 0 comments
Open

[action-menu, input-number] Restore unstable tests #9784

jcfranco opened this issue Jul 15, 2024 · 0 comments
Labels
0 - new New issues that need assignment. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.
Milestone

Comments

@jcfranco
Copy link
Member

jcfranco commented Jul 15, 2024

Priority impact

p - high

Test type

E2E Test

Which Component(s)

calcite-action-menu, calcite-input-number

Unstable Tests

  • calcite-action-menu › should close menu if slotted action is clicked test(action-menu): restore tests #10921
  • calcite-input-number › should stop increasing the value when pointer is moved away from the increment button

Test error, if applicable

@esri/calcite-components:test: FAIL src/components/action-menu/action-menu.e2e.ts (19.686 s)
@esri/calcite-components:test:   ● calcite-action-menu › should close menu if slotted action is clicked
@esri/calcite-components:test: 
@esri/calcite-components:test:     expect(received).toBe(expected) // Object.is equality
@esri/calcite-components:test: 
@esri/calcite-components:test:     Expected: false
@esri/calcite-components:test:     Received: true
@esri/calcite-components:test: 
@esri/calcite-components:test:       197 |     await page.waitForChanges();
@esri/calcite-components:test:       198 |
@esri/calcite-components:test:     > 199 |     expect(await actionMenu.getProperty("open")).toBe(false);
@esri/calcite-components:test:           |                                                  ^
@esri/calcite-components:test:       200 |
@esri/calcite-components:test:       201 |     const focusTargetSelector = `#triggerAction`;
@esri/calcite-components:test:       202 |     expect(await page.evaluate((selector) => document.activeElement.matches(selector), focusTargetSelector)).toBe(true);
@esri/calcite-components:test: 
@esri/calcite-components:test:       at Object.<anonymous> (src/components/action-menu/action-menu.e2e.ts:199:50)
@esri/calcite-components:test: 
@esri/calcite-components:test: FAIL src/components/input/input.e2e.ts (510.561 s)
@esri/calcite-components:test:   ● calcite-input › input type number increment/decrement functionality › should stop increasing the value when pointer is moved away from the increment button
@esri/calcite-components:test: 
@esri/calcite-components:test:     expect(received).toEqual(expected) // deep equality
@esri/calcite-components:test: 
@esri/calcite-components:test:     Expected: "20"
@esri/calcite-components:test:     Received: "21"
@esri/calcite-components:test: 
@esri/calcite-components:test:       702 |       await page.mouse.move(incrementButtonRect.x, 2 * incrementButtonRect.bottom);
@esri/calcite-components:test:       703 |       await page.waitForChanges();
@esri/calcite-components:test:     > 704 |       expect(await input.getProperty("value")).toEqual(value);
@esri/calcite-components:test:           |                                                ^
@esri/calcite-components:test:       705 |
@esri/calcite-components:test:       706 |       await page.mouse.up();
@esri/calcite-components:test:       707 |       await page.waitForChanges();
@esri/calcite-components:test: 
@esri/calcite-components:test:       at Object.<anonymous> (src/components/input/input.e2e.ts:704:48)

PR skipped, if applicable

#9783

Additional Info

No response

@jcfranco jcfranco added testing Issues related to automated or manual testing. 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Jul 15, 2024
@github-actions github-actions bot added the p - high Issue should be addressed in the current milestone, impacts component or core functionality label Jul 15, 2024
@jcfranco jcfranco changed the title Restore unstable tests [action-menu, input-number] Restore unstable tests Jul 15, 2024
@geospatialem geospatialem added this to the 2024-10-29 - Oct Release milestone Aug 7, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Aug 7, 2024
@geospatialem geospatialem added the estimate - 5 A few days of work, definitely requires updates to tests. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.
Projects
None yet
Development

No branches or pull requests

2 participants