Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Time Picker] Reconsider use of shadow #9533

Open
2 of 8 tasks
ashetland opened this issue Jun 6, 2024 · 2 comments
Open
2 of 8 tasks

[Time Picker] Reconsider use of shadow #9533

ashetland opened this issue Jun 6, 2024 · 2 comments
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - sm Small design effort; 1-4 days of design work estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Milestone
2025-05-13 - 3.2....

Comments

@ashetland
Copy link
Contributor

ashetland commented Jun 6, 2024 •
edited
Loading

Check existing issues

Description

Time Picker is styled with a shadow, but Date Picker and Color Picker are not. When Time Picker is used in Input Time Picker it is currently placed inside a Popover, effectively doubling its shadow.
CleanShot 2024-06-03 at 11 19 13@2x (1)
CleanShot 2024-06-03 at 11 19 19@2x (1)

Acceptance Criteria

To align with Color Picker and Date Picker:

  • Remove shadow
  • Add 1px border using border.3

Figma reference

CleanShot 2024-10-10 at 14 36 52@2x

Relevant Info

No response

Which Component

Time Picker

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@ashetland ashetland added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 6, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jun 6, 2024
@ashetland ashetland added the design Issues that need design consultation prior to development. label Jun 6, 2024
@DitwanP DitwanP added p - low Issue is non core or affecting less that 10% of people using the library estimate - design - sm Small design effort; 1-4 days of design work and removed needs triage Planning workflow - pending design/dev review. labels Jun 13, 2024
@DitwanP DitwanP added this to the Design Backlog milestone Jun 13, 2024
@ashetland ashetland mentioned this issue Jul 11, 2024
Open
14 tasks
@DitwanP DitwanP removed this from the Design Backlog milestone Aug 8, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Sep 16, 2024
@ashetland ashetland added the ready for dev Issues ready for development implementation. label Oct 10, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem added the estimate - 3 A day or two of work, likely requires updates to tests. label Oct 10, 2024
@ashetland ashetland added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. label Oct 10, 2024
@ashetland
Copy link
Contributor Author

Should be paired with #9758

@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - sm Small design effort; 1-4 days of design work estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Milestone
2025-05-13 - 3.2.0 May Main Release
Development

No branches or pull requests
3 participants
@geospatialem @DitwanP @ashetland