Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calcite-input-number - Prevent Invalid Local Characters in Calcite Number Input #9384

Closed
2 of 6 tasks
suc97686 opened this issue May 21, 2024 · 1 comment
Closed
2 of 6 tasks

Calcite-input-number - Prevent Invalid Local Characters in Calcite Number Input #9384

suc97686 opened this issue May 21, 2024 · 1 comment
Labels
0 - new New issues that need assignment. ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. i18n-l10n issues dealing with internationalization/localization impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2025-03-25 - 3.1....

Comments

@suc97686
Copy link

Check existing issues

Actual Behavior

The Calcite number input component currently allows users to enter characters that are not valid for numerical inputs.

Invalid_characters.1.mp4

Expected Behavior

It should not allow users to add invalid local characters or should throw an error message

Reproduction Sample

https://devtopia.esri.com/WebGIS/arcgis-web-analysis/issues/5838

Reproduction Steps

1.Launch map viewer from app launcher, then open Analysis panel and click Raster Functions/ Tools.
2.Click New Raster Function Template button, then click Add raster function.
3.Expand "Hydrology", click "+" button next to "Fill".
4.Input number (e.g. 2) in textbox of Z limit. –key step
5.Change the input method to simple Chinese. - key step
6.Try to input local characters (e.g. "测试","《", "!", which should be invalid in number input box) after the inputted number. –key step

Reproduction Version

2.7

Relevant Info

No response

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Web Analysis
@suc97686 suc97686 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels May 21, 2024
@github-actions github-actions bot added p3 - want for upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members labels May 21, 2024
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@annierm18 annierm18 added the i18n-l10n issues dealing with internationalization/localization label May 21, 2024
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Jun 4, 2024
@geospatialem geospatialem added this to the 2025-01-28 - Jan Release milestone Aug 7, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Aug 7, 2024
@geospatialem
Copy link
Member

Apologies for not spotting this sooner, the above is a duplicate of #8640, which is targeted for March. Added the ArcGIS Web Analysis label to the corresponding issue for tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. i18n-l10n issues dealing with internationalization/localization impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2025-03-25 - 3.1.0 Mar Release
Development

No branches or pull requests
3 participants
@geospatialem @annierm18 @suc97686