Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

label: replace "default" value with a more meaningful value. #9184

Open
1 of 5 tasks
driskull opened this issue Apr 24, 2024 · 4 comments
Open
1 of 5 tasks

label: replace "default" value with a more meaningful value. #9184

driskull opened this issue Apr 24, 2024 · 4 comments
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Milestone
2025-07-29 - 3.3....

Comments

@driskull
Copy link
Member

Description

Deprecate the "default" value on label and add a new value that better describes the value

Proposed Advantages

More meaningful definition of values

Which Component

label

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@driskull driskull added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 24, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Apr 24, 2024
@macandcheese
Copy link
Contributor

If we still plan on removing Label as a standalone component (#8572) - is this needed? Using it as a "layout wrapper" as it currently is posited isn't the best IMO in general.

@driskull
Copy link
Member Author

If we remove label then this isn't needed 👍

@macandcheese
Copy link
Contributor

If we did want to add this now, block would work for default.

@geospatialem geospatialem added breaking change Issues and pull requests with code changes that are not backwards compatible. estimate - 2 Small fix or update, may require updates to tests. future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. p - medium Issue is non core or affecting less that 60% of people using the library and removed breaking change Issues and pull requests with code changes that are not backwards compatible. labels Sep 26, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Sep 26, 2024
@geospatialem
Copy link
Member

Calcite should deprecate the default value, but still offer it until removal in 4.0 later in 2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2025-07-29 - 3.3.0 Jul Release
Development

No branches or pull requests
3 participants
@driskull @macandcheese @geospatialem