Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Panel] Add -space css properties for header-content slot #8907

Closed
2 of 6 tasks
Tracked by #7180
macandcheese opened this issue Mar 8, 2024 · 3 comments
Closed
2 of 6 tasks
Tracked by #7180

[Panel] Add -space css properties for header-content slot #8907

macandcheese opened this issue Mar 8, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library p4 - not time sensitive User set priority status of p4 - not time sensitive
Milestone
2024-12-17 - Dec ...

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Mar 8, 2024 •
edited by geospatialem
Loading

Check existing issues

Description

It is common to slot rich content into the header-content slot of a Panel. Currently, they have baked-in padding that isn't always desirable - where slotted items are intended to be full-height.

I'd like to have the ability to remove this with a calcite-panel-header-content-space (or similarly named) css property.

Acceptance Criteria

I have the ability to control the padding of the slots mentioned above.

Example Use Case

Screenshot 2024-03-07 at 9 19 06 PM Screenshot 2024-03-07 at 9 20 15 PM

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. estimate - 2 Small fix or update, may require updates to tests. design-tokens Issues requiring design tokens. labels Mar 8, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive Calcite (design) Issues logged by Calcite designers. labels Mar 8, 2024
@macandcheese
Copy link
Contributor Author

Seems like --calcite-panel-footer-space already exists, missed that. Request stands for header-content 😄

@geospatialem geospatialem mentioned this issue Aug 27, 2024
Open
@geospatialem geospatialem added the p - low Issue is non core or affecting less that 10% of people using the library label Aug 27, 2024
@geospatialem geospatialem changed the title [Panel] Add -space css properties for header-content and footer slots [Panel] Add -space css properties for header-content slot Aug 27, 2024
@github-actions github-actions bot added the p4 - not time sensitive User set priority status of p4 - not time sensitive label Aug 27, 2024
@geospatialem geospatialem added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Aug 27, 2024
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Dec 13, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Dec 13, 2024

🍡 Verified locally on dev
image

@DitwanP DitwanP closed this as completed Dec 13, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library p4 - not time sensitive User set priority status of p4 - not time sensitive
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

No branches or pull requests
3 participants
@macandcheese @geospatialem @DitwanP