Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calcite-text-area: width not calculated correctly #8654

Open
2 of 6 tasks
AdelheidF opened this issue Jan 26, 2024 · 5 comments
Open
2 of 6 tasks

calcite-text-area: width not calculated correctly #8654

AdelheidF opened this issue Jan 26, 2024 · 5 comments
Assignees
Labels
2 - in development Issues that are actively being worked on. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.

Comments

@AdelheidF
Copy link

AdelheidF commented Jan 26, 2024

Check existing issues

Actual Behavior

Narrow shell area
image

Wide shell area
image

Expected Behavior

input and text-area right border always align vertically

Reproduction Sample

https://codepen.io/afreitag/pen/WNmXZPm

Reproduction Steps

Open codepen and look

Reproduction Version

2.3.0

Relevant Info

No response

Regression?

don't think so

Priority impact

p2 - want for current milestone

Impact

won't use text-area until this is fixed

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Map Viewer

@AdelheidF AdelheidF added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 26, 2024
@github-actions github-actions bot added ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Jan 26, 2024
@jcfranco jcfranco added estimate - 5 A few days of work, definitely requires updates to tests. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library labels Feb 29, 2024
@jcfranco
Copy link
Member

@anveshmekala Can you take a look at the estimate and adjust if needed?

@anveshmekala
Copy link
Contributor

@anveshmekala Can you take a look at the estimate and adjust if needed?

The current estimate looks good.

@macandcheese
Copy link
Contributor

macandcheese commented Mar 22, 2024

You can also drag the text-area to be wider than the width of it's parent. I'd expect it to only extend to the parent's extent. Not sure if this issue is the appropriate place but mentioning it here.

Screen.Recording.2024-03-21.at.5.20.09.PM.mov

@anveshmekala
Copy link
Contributor

You can also drag the text-area to be wider than the width of it's parent. I'd expect it to only extend to the parent's extent. Not sure if this issue is the appropriate place but mentioning it here.

Thanks for bring this up. This is consistent with native <textarea/> element https://codepen.io/ANVESHMEKALA/pen/rNbmyjz. Workaround is to add max-width property on <textarea/> element inside shadowDOM of calcite-text-area to restrict the resizing behavior. We can provide this option via @prop may be. Thoughts?

@macandcheese
Copy link
Contributor

Yeah, I generally do like to default to matching native functionality - but not sure if it is a benefit to a user here or it could be an improvement our component has there. Could also be a discussion for a separate issue if it's out of scope here.

@geospatialem geospatialem added this to the 2024-07-30 - Jul Release milestone Apr 3, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@geospatialem geospatialem added the has workaround Issues have a workaround available in the meantime. label Jul 1, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Dec 16, 2024
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 8, 2025
@geospatialem geospatialem added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Feb 24, 2025
@geospatialem geospatialem removed this from the 2025-03-25 - 3.1.0 Mar Release milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - in development Issues that are actively being worked on. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Projects
None yet
Development

No branches or pull requests

5 participants