Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error thrown when closing tabs when these use the tab prop #8587

Open
2 of 6 tasks
jcfranco opened this issue Jan 10, 2024 · 1 comment
Open
2 of 6 tasks

Error thrown when closing tabs when these use the tab prop #8587

jcfranco opened this issue Jan 10, 2024 · 1 comment
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library

Comments

@jcfranco
Copy link
Member

Check existing issues

Actual Behavior

When you have closable tabs using the tab prop on both tab-title and tab components, the following error is thrown whenever a tab is closed.

tab-nav.tsx:413 Uncaught TypeError: Cannot read properties of undefined (reading 'focus')
    at tab-nav.tsx:413:37

Expected Behavior

Closing tabs raises no errors in the console.

Reproduction Sample

https://codepen.io/jcfranco/pen/NWJrJBW

Reproduction Steps

  1. close any tab
  2. observe the error thrown in the console

Reproduction Version

2.1.0

Relevant Info

Error is thrown here.

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 10, 2024
@jcfranco jcfranco changed the title Error thrown when closing tabs when these use the tab Error thrown when closing tabs when these use the tab prop Jan 10, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jan 10, 2024
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jan 11, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 29, 2024
@jcfranco jcfranco mentioned this issue Apr 8, 2024
Closed
6 tasks
@nel11211
Copy link

+1 seeing this in MV during tabs implementation work.

@geospatialem geospatialem added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @DitwanP @nel11211