Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calcite-input-date-picker (range) has no viable hidden label for screen readers #8480

Open
2 of 6 tasks
abp6318 opened this issue Dec 21, 2023 · 3 comments
Open
2 of 6 tasks
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. ArcGIS Hub Issues logged by ArcGIS Hub team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library spike complete Issues that have a research spike completed and dev work can proceed

Comments

@abp6318
Copy link
Contributor

abp6318 commented Dec 21, 2023

Check existing issues

Actual Behavior

Tabbing over the calcite-input-date-picker (range) OR using CTRL + OPTION + ARROWS does not read aloud the following:

  • a label attribute (currently not supported)
  • a label wrapping the element that is hidden or visible
  • a label referencing the input with aria-labelledby

While aria-label does work, it results in a "serious" issue with axeDev tools.

Expected Behavior

That a screen reader can read aloud 1 or more of the following when referencing a calcite-input-date-picker (range):

  • a label attribute (currently not supported)
  • a label wrapping the element that is hidden or visible
  • a label referencing the input with aria-labelledby

Reproduction Sample

https://codepen.io/abp6318/pen/LYaYVaE?editors=1000

Reproduction Steps

  1. Open Chrome, Firefox, or Safari
  2. Use COMMAND + F5 on Mac, or turn on a screen reader of your choice
  3. Navigate to the input using tab or CTRL + OPTION + ARROWS

Reproduction Version

1.11

Relevant Info

MacBook Pro
16 inch 2023
Apple M2 Chip
32 GB
macOS Sonoma 14.1.2
Chrome
Default screen reader

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

Users who need screen readers cannot hear any text related to date inputs. Out specific use case is for date range validation.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Hub

@abp6318 abp6318 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Dec 21, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Hub Issues logged by ArcGIS Hub team members. p3 - want for upcoming milestone labels Dec 21, 2023
@geospatialem
Copy link
Member

Related: #7993

@geospatialem geospatialem added the spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. label Feb 7, 2024
@geospatialem geospatialem self-assigned this Feb 7, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Feb 7, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Feb 7, 2024
@geospatialem
Copy link
Member

Spike results

It appears like the current value is read via the date format's placeholder text.

<span aria-hidden="true" class={CSS.assistiveText} id={this.placeholderTextId}>
Date Format: {this.localeData?.placeholder}
</span>

Would recommend we try to:

  • If an applicable calcite-label is present supply the value to AT
    • In addition to the component's value, if present
  • Add a new label property that supersedes a calcite-label
    • In addition to the component's value, if present
  • If none of the above are true, the current state can remain as-is

@geospatialem geospatialem added the spike complete Issues that have a research spike completed and dev work can proceed label Feb 7, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 7, 2024
Copy link
Contributor

github-actions bot commented Feb 7, 2024

cc @geospatialem, @brittneytewks

@geospatialem geospatialem added a11y Issues related to Accessibility fixes or improvements. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. labels Feb 7, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. ArcGIS Hub Issues logged by ArcGIS Hub team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library spike complete Issues that have a research spike completed and dev work can proceed
Projects
None yet
Development

No branches or pull requests

2 participants