-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calcite-pagination does not use its available space #8369
Comments
@macandcheese do you think it would be nice for the pagination to have an alignment property or something similar? |
Also @driskull could you remind me if there were key limitations with Pagination populating as many pages as it could afford in the available width verses a prescribed number of pages per breakpoint? |
Thank you, @driskull--that works perfectly in my app! Should the pagination fill the space given it? (I no longer need it for my app--just curious.) |
Not all pages are the same width so we can't do that. We would need each page to be the same width. |
Could be if thats what we decide. |
The pagination does fill the width its given, but without making each page's padding or width adjustable we can't fully fill the items within it. |
Since this issue has been resolved by Matt, may I close it? Skye's proposal can be a new issue for discussion. |
@SkyeSeitz @macandcheese would like your thoughts on this one. If we should have a property for alignment or not. The only other way to not have alignment not matter is if we stretch something within each page (width/padding/spacing/etc) to make it fill the space. |
It seems like we are leaning that way based on the current state - where the pagination container fills the width but does not fill that width with additional pages. So in this context, I do think making the component automatically adjust - displaying as many "pages" as possible within a container size - would be nice, but out of scope for now. |
I originally had this in the responsive PR but design wanted each page's padding to be consistent. |
Closing issue. @SkyeSeitz feel free to open a new one for any ui enhancements. |
Check existing issues
Actual Behavior
calcite-pagination changes its display based on width, but it's not clear how to control this. E.g., I'd like to center the pagination component under a gallery. I specify a width for it and centering margins, but I see that the component is not filling the width that I give it. If I decrease the width, less of the pagination is shown even though there's available space:
(background color is applied to pagination component to show its width)
I've also tried using a containing div, but get the same non-filling behavior. (https://codepen.io/miketschudi/pen/GRzzwpJ?editors=100)
Expected Behavior
I expect the component to fill the available width.
Reproduction Sample
https://codepen.io/miketschudi/pen/XWOOxOZ?editors=100
Reproduction Steps
Reproduction Version
2.0.0
Relevant Info
Windows 10 Chrome 119.0, Firefox 120.0
Regression?
No response
Priority impact
p4 - not time sensitive
Impact
Minor impact--just UI misalignment that I'm sure to receive a bug report about. :-)
Calcite package
Esri team
ArcGIS Solutions
The text was updated successfully, but these errors were encountered: