Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown, Dropdown Group, Dropdown - Ensure ARIA roles, states, and properties are valid - (2047835829) #7849

Closed
Tracked by #7851
dqateam opened this issue Sep 19, 2023 · 1 comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Ensure ARIA roles, states, and properties are valid

WCAG Reference:

Severity:

5

Media Type:

ARIA


Areas for Remediation:

  • Title: Dropdown, Dropdown Group, Dropdown - Ensure ARIA roles, states, and properties are valid - (2047835829)
  • Module: Dropdown, Dropdown Group, Dropdown
    Issue
    When a control is marked disabled, aria-disabled can cause confusion.

User Impact
When ARIA attributes (state, roles, and properties) are inappropriately used or not used correctly, assistive technology may not correctly function as expected. Role and properties are covenants between assistive technology and the application and must be accurate for the intended purpose. Valid markup should always be used.

Code Reference

<div calcite-hydrated="" aria-disabled="true" tabindex="-1" type="click" scale="m" placement="bottom-start" disabled=""><div class="calcite-dropdown-trigger-container" id="calcite-dropdown-b6ef2aa8-d515-5027-6318-61410cda72be-menubutton"><div icon-end="hamburger" appearance="outline" slot="dropdown-trigger" alignment="center" color="blue" scale="m" width="auto" calcite-hydrated=""><button aria-label="" class="content--slotted icon-start-empty" type="button"><span class="content">Disabled</span><div class="icon icon--end" aria-hidden="true" icon="hamburger" scale="s" calcite-hydrated=""><svg class="svg" fill="currentColor" height="100%" viewbox="0 0 16 16" width="100%" xmlns="http://www.w3.org/2000/svg"><path d=""></path></svg></div></button></div></div><div aria-hidden="true" class="calcite-dropdown-wrapper" data-placement="top-start" style="visibility: hidden; pointer-events: none; position: absolute; top: 0px; left: 0px; transform: translate(289px, 1009px);"><div aria-labelledby="calcite-dropdown-b6ef2aa8-d515-5027-6318-61410cda72be-menubutton" class="calcite-dropdown-content calcite-floating-ui-anim" id="calcite-dropdown-b6ef2aa8-d515-5027-6318-61410cda72be-menu" role="menu" style="min-width: 107px;"><div hidden="">

Suggestion
Developers must use valid markup and follow the rules of the ARIA specification as well as correctly setting ARIA properties, including roles based on the intended purpose.

Compliant Code Example

This DIV does not need an aria-disabled attribute, as it has a disabled attribute

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@geospatialem
Copy link
Member

Closing in favor of the epic across components, #7775.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

2 participants