Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell and Shell Panel - Avoid placing inactive elements in the focus order - (2036570586) #7826

Closed
Tracked by #7851
dqateam opened this issue Sep 19, 2023 · 3 comments
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Avoid placing inactive elements in the focus order

image

WCAG Reference:

Severity:

5

Media Type:

Keyboard Accessibility


Areas for Remediation:

  • Title: Shell and Shell Panel - Avoid placing inactive elements in the focus order - (2036570586)
  • Module: Shell and Shell Panel
    Pattern: Keyboard-focusable-list items]

Issue
The below-mentioned content receives focus because it has been provided with tabindex="0" attribute which places them in the focus order.
Examples included:

  • Item 1
  • Item 2
  • Item 3 of "A filter-enabled value list" section.

Occurrences
29 Shell and Shell Panel
30 Shell Center Row

User Impact
Keyboard-only users will be able to navigate to this element even if it is off screen. Screen reader users will be able to focus this element if they press Tab, but they will be unable to determine its purpose.

Code Reference

<label aria-label="Item 1" class="label" tabindex="0"><div aria-checked="false" class="text-container" role="menuitemcheckbox"><span class="title">Item 1</span>

Suggestion
Developers should remove the tabindex="0" from the mentioned content so that it does not receive keyboard focus.

Compliant Code Example


<label aria-label="Item 1" class="label"><div aria-checked="false" class="text-container" role="menuitemcheckbox"><span class="title">Item 1</span>

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@driskull
Copy link
Member

I think this is for the pick-list? Its not a shell/panel thing.

@macandcheese
Copy link
Contributor

Agreed - referenced code is not part of these components. Could we close this one?

@geospatialem
Copy link
Member

This relates to our deprecated value-list, closing out as no effort is planned on the deprecated component.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

4 participants