Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell and Shell Panel - Avoid inappropriate use of ARIA roles, states, and properties - (2036570593) #7825

Closed
Tracked by #7851
dqateam opened this issue Sep 19, 2023 · 2 comments
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Avoid inappropriate use of ARIA roles, states, and properties

WCAG Reference:

Severity:

5

Media Type:

ARIA


Areas for Remediation:

  • Title: Shell and Shell Panel - Avoid inappropriate use of ARIA roles, states, and properties - (2036570593)
  • Module: Shell and Shell Panel
    Pattern: ARIA - Inappropriate use of aria attribute-role menu, menuitemcheckbox ]

Issue
The list item elements of the "A filter-enabled value list" section. with inappropriate use of aria-label, menu, menuitemcheckbox ,aria-busy,etc attributes.

Occurrences
29 Shell and Shell Panel
30 Shell Center Row

User Impact
When inappropriate ARIA roles, states, and/or properties are used, screen reader users will mistake these elements for other control structures or the use may prevent users of assistive technology from interacting with the control.

Code Reference

<calcite-value-list multiple="" aria-busy="false" role="menu" calcite-hydrated=""> <calcite-value-list-item label="Item 1" description="Lightning bolt" value="lightning" id="calcite-value-list-item-ffbab611-0e05-e1af-8c17-a025cabef213" calcite-hydrated="">
           (...)
<label aria-label="Item 1" class="label" tabindex="0"><div aria-checked="true" class="text-container" role="menuitemcheckbox"><span class="title">Item 1</span><span class="description">Lightning bolt</span></div></label>

Suggestion
Developers must avoid inappropriate use of ARIA roles, states, and/or properties. Remove any unnecessary ARIA attributes such as aria-label, menu, menuitemcheckbox ,aria-busy, aria-checked, aria-expanded and aria-labelledby used on section element.

Compliant Code Example

<calcite-value-list multiple="" calcite-hydrated=""> <calcite-value-list-item label="Item 1" description="Lightning bolt" value="lightning" id="calcite-value-list-item-ffbab611-0e05-e1af-8c17-a025cabef213" calcite-hydrated="">
           (...)
<div class="text-container"><span class="title">Item 1</span><span class="description">Lightning bolt</span></div>

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@macandcheese
Copy link
Contributor

This seems unrelated to Shell or Shell Panel - referenced code is not part of these components. Could we close this one?

@geospatialem
Copy link
Member

The issue refers to our deprecated value-list component, closing as no efforts are planned at this time.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants