Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice - Avoid placing inactive elements in the focus order - (2036570066) #7803

Closed
Tracked by #7851
dqateam opened this issue Sep 19, 2023 · 2 comments
Closed
Tracked by #7851
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Avoid placing inactive elements in the focus order

WCAG Reference:

Severity:

5

Media Type:

Keyboard Accessibility


Areas for Remediation:

  • Title: Notice - Avoid placing inactive elements in the focus order - (2036570066)
  • Module: Notice
    Issue
    The "Notice with tabindex" and "Notice message" non interactive content receives focus because it has been provided with tabindex="0" attribute which places them in the focus order.

User Impact
Keyboard-only users will be able to navigate to this element even if it is off screen. Screen reader users will be able to focus this element if they press Tab, but they will be unable to determine its purpose.

Code Reference

<div slot="title" tabindex="0">Notice with tabindex</div>
<div slot="message" tabindex="0">Notice message</div>

Suggestion
Developers should remove the tabindex="0" from the div element so that it does not receive keyboard focus.

Compliant Code Example

<div slot="title">Notice with tabindex</div>
<div slot="message">Notice message</div>

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@macandcheese
Copy link
Contributor

Can we close this one? This is a result of the configuration of slotted elements, nothing supplied by the component should do this.

@geospatialem
Copy link
Member

Can we close this one? This is a result of the configuration of slotted elements, nothing supplied by the component should do this.

Good catch, yes, we can close, a tabindex was added in as a test to the audit, which is not the pattern we provide folks.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants