Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating - Ensure parts of graphical objects essential for understanding content have sufficient contrast - (2036570022) #7798

Open
dqateam opened this issue Sep 19, 2023 · 9 comments
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. design Issues that need design consultation prior to development. estimate - design - sm Small design effort; 1-4 days of design work estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Ensure parts of graphical objects essential for understanding content have sufficient contrast

image

WCAG Reference:

Severity:

5

Media Type:

Color and Contrast


Areas for Remediation:

  • Title: Rating - Ensure parts of graphical objects essential for understanding content have sufficient contrast - (2036570022)
  • Module: Rating
    Issue
    There are graphical objects with a color contrast ratio below 3.00:1.

Foreground: #EDD317
Background: #F8F8F8
Contrast ratio: 1.4:1

Examples include:

  • Test 2. Average Rating
  • Test 3. Average with chip

User Impact
Users with low vision will have difficulty identifying this content.

Code Reference

<svg class="svg" fill="currentColor" height="100%" viewBox="0 0 24 24" width="100%" xmlns="http://www.w3.org/2000/svg">
...
</svg>


Suggestion
Ensure parts of graphical objects essential for understanding content have sufficient contrast. The required minimum contrast ratio is 3.00:1.

Common examples of qualifying objects include lines in a chart, meaningful icons, and annotations within an image.

Graphics that require particular presentation to preserve their meaning are exempt from this requirement.

To evaluate color contrast, see the Accessible Color Picker extension: https://www.accessibility.dev/


Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@geospatialem geospatialem added the design Issues that need design consultation prior to development. label Dec 27, 2023
@geospatialem
Copy link
Member

For design consideration, should we accommodate color contrast with rating, or does the outline of each item provide sufficient contrast and we can close the above? cc @ashetland @SkyeSeitz

@SkyeSeitz
Copy link

Thanks, @geospatialem. Would like to explore a potential change to the yellow star color displayed for the average prop.

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - design - sm Small design effort; 1-4 days of design work labels May 9, 2024
@geospatialem geospatialem added this to the Design Backlog milestone May 9, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label May 9, 2024
@jacqueskeet
Copy link

jacqueskeet commented May 15, 2024

During the exploration of this, we realised that the Read-only property of this component is missing. We should explore adding it back as part of this ticket. Here's a design example of what it should look like.

Rating - Read only

@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels May 15, 2024
@DitwanP DitwanP removed this from the Design Backlog milestone Jul 11, 2024
@jacqueskeet
Copy link

jacqueskeet commented Jul 26, 2024

Following the design exploration, we decided to update the global warning color used in the Rating component. The Warning token color has been adjusted, providing sufficient contrast with the Rating component.

Link fo Figma:
https://www.figma.com/design/rkpMoRvtpYb9SD9dYHXg2i/%5BRating%5D-star-color-accessibility?node-id=547-8706&t=AEBuNETvNwMxHt82-4

image

We're aware that this is a global change hence we identified two potential risks associated with this change:
1. other components that uses this color;
2. a potential contrast issue next to the danger color;

We looked at the components that are using the Warning color and found that there’s no immediate issues.

image

We also ran a few visual impairment contrast tests between the same components using the new warning color and the danger color and found that there’s no issues as well.

Example of Protanopia
image

@jacqueskeet jacqueskeet removed the design Issues that need design consultation prior to development. label Jul 26, 2024
@ashetland ashetland added the design Issues that need design consultation prior to development. label Jul 26, 2024
@geospatialem geospatialem added the ready for dev Issues ready for development implementation. label Jul 29, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 29, 2024
Copy link
Contributor

github-actions bot commented Jul 29, 2024

cc @geospatialem,. @brittneytewks

@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. ready for dev Issues ready for development implementation. labels Jul 29, 2024
@geospatialem geospatialem added the ready for dev Issues ready for development implementation. label Jul 29, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 29, 2024
Copy link
Contributor

cc @geospatialem, @brittneytewks

@SkyeSeitz
Copy link

During the exploration of this, we realized that the Read-only property of this component is missing. We should explore adding it back as part of this ticket...

As mentioned above, in addition to updating the warning colors, can we also implement an updated read-only styling to improve distinction? This change would use the star-f icon with a border.1 fill to distinguish itself from the outlined star used in the default state.
image

@geospatialem geospatialem added the estimate - 5 A few days of work, definitely requires updates to tests. label Jul 31, 2024
@geospatialem geospatialem added this to the 2025-01-28 - Jan Release milestone Sep 6, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 6, 2024
@geospatialem geospatialem added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. label Nov 20, 2024
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. and removed enhancement Issues tied to a new feature or request. labels Dec 3, 2024
@jcfranco
Copy link
Member

@geospatialem @SkyeSeitz @jacqueskeet Can we create a separate issue for the design improvements (e.g., read-only support, global warning color tweak)? This was originally scoped to the contrast of the existing design. Alternatively, we could repurpose this issue to focus on the improvements and add the a11y requirements to the acceptance criteria if that’s preferable.

@SkyeSeitz
Copy link

Good thought, Franco. Since a design re-work is needed in order to address the a11y issue, I would be in favor of repurposing this issue with a11y requirements to the acceptance criteria.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. design Issues that need design consultation prior to development. estimate - design - sm Small design effort; 1-4 days of design work estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Development

No branches or pull requests

7 participants