Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Pad and Action - Provide valid, concise, and meaningful alternative text for image buttons - (2036569767) #7779

Closed
dqateam opened this issue Sep 19, 2023 · 2 comments
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Provide valid, concise, and meaningful alternative text for image buttons

image

WCAG Reference:

Severity:

6

Media Type:

Forms


Areas for Remediation:

  • Title: Action Pad and Action - Provide valid, concise, and meaningful alternative text for image buttons - (2036569767)

  • Module: Action Pad and Action
    Issue
    There are expand/collapse image buttons that do not provide the complete accessible names. The expand/collapse state is defined using an accessible name. Examples include:

  • Action pad

  • Action pad small scale

  • Action pad expanded

  • Action pad horizontal layout

  • Action pad grid layout

User Impact
Without meaningful alternative text, any information conveyed by these image buttons will not be conveyed to screen reader users and they will be announced as unlabeled buttons.

Code Reference

<button aria-busy="false" aria-disabled="false" aria-label="Expand" class="button">
 <div aria-hidden="true" class="icon-container">
   (...)
 </div>
 <div class="text-container">Expand</div>
</button>

Suggestion
Ensure that image buttons provide meaningful alternative text. This can be achieved by providing an aria-label for <button> elements.

Compliant Code Example

<button aria-busy="false" aria-disabled="false" aria-label="Action pad Expand" class="button">
 <div aria-hidden="true" class="icon-container">
   (...)
 </div>
 <div class="text-container">Expand</div>
</button>

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@driskull
Copy link
Member

Seems like an app issue. Can use the label property here.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 0 - new New issues that need assignment. labels Dec 27, 2023
@geospatialem
Copy link
Member

This has been mitigated prior to 2.0.0 with the "expand-tooltip" slot to provide specific context when the action-pad is collapsed to provide context on expansion, and also provides the "collapse" context. Both the "expand" and "collapse" strings can be modified by the developer for additional configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants