Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel debounced and throttled functions #7060

Open
driskull opened this issue May 30, 2023 · 1 comment
Open

Cancel debounced and throttled functions #7060

driskull opened this issue May 30, 2023 · 1 comment
Assignees
@Elijbet
Labels
1 - assigned Issues that are assigned to a sprint and a team member. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Milestone
2025-03-25 - 3.1....

Comments

@driskull
Copy link
Member

driskull commented May 30, 2023 •
edited
Loading

Description

We need to cancel all debounced and throttled functions when the component is disconnected or when the component no longer needs to handle the debounced function.

Proposed Advantages

Debounced functions no longer happen after the component is removed from the DOM.

Which Component

Throttle

  • color-picker
  • slider
  • text-area

Debounce

  • action-bar
  • combobox
  • filter
  • list
  • slider

Relevant Info

https://lodash.com/docs/4.17.15#debounce
https://lodash.com/docs/4.17.15#throttle
@driskull driskull added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 30, 2023
@driskull driskull added the p - low Issue is non core or affecting less that 10% of people using the library label Jan 22, 2024
@geospatialem geospatialem added estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Apr 2, 2024
@geospatialem geospatialem added this to the 2024-11-19 - Nov Release milestone Apr 3, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@Elijbet Elijbet self-assigned this Oct 23, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Oct 23, 2024
@Elijbet Elijbet mentioned this issue Oct 24, 2024
Draft
@Elijbet Elijbet added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 24, 2024
@Elijbet
Copy link
Contributor

Elijbet commented Oct 25, 2024

This issue is blocked until Lumina is installed. The specific test I’m using here is not possible in E2E tests right now.
There's no way in the current E2E environment to assert on utils that the components are using at runtime. This might be possible with Lumina migration, so we will wait for that before proceeding.

@Elijbet Elijbet added the blocked This issue is blocked by another issue. label Oct 25, 2024
@Elijbet Elijbet closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
@Elijbet Elijbet reopened this Oct 25, 2024
@geospatialem geospatialem removed the blocked This issue is blocked by another issue. label Jan 13, 2025
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 2 - in development Issues that are actively being worked on. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Elijbet Elijbet

Labels
1 - assigned Issues that are assigned to a sprint and a team member. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2025-03-25 - 3.1.0 Mar Release
Development

No branches or pull requests
4 participants
@driskull @geospatialem @Elijbet @DitwanP