Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot coverage for date-picker styles for when there is an active range selection. #6314

Closed
Elijbet opened this issue Jan 20, 2023 · 3 comments
Labels
0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Jan 20, 2023

Test type

new test

Which Component(s)

date-picker

Unstable Tests

No response

Test error, if applicable

No response

PR skipped, if applicable

Additional Info

Follow up on comment #6216 (comment) ttps://github.com/Esri/calcite-components/pull/6216#discussion_r1082024483 . .

Any JS needs to go into a play function which doesn't work OOTB with custom elements. @benelan will be looking into the play function implementation after v1, so we can add something along these lines:

const selectRangeString = html`
<script>
let weekDays = document.querySelector(".week-days");
weekDays.querySelector("calcite-date-picker-day:first-child").selected = true;
weekDays.querySelector("calcite-date-picker-day:last-child").selected = true;
</script>
`;
export const range_TestOnly = (): string =>
html`<div style="width: 400px">
<calcite-date-picker range></calcite-date-picker>
</div>
${selectRangeString}`;

export const rangeRTL_TestOnly = (): string =>
html`<div style="width: 400px">
<calcite-date-picker dir=“rtl” range></calcite-date-picker>
</div>
${selectRangeString}`;
@Elijbet Elijbet added testing Issues related to automated or manual testing. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. p - low Issue is non core or affecting less that 10% of people using the library and removed p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Jan 20, 2023
@Elijbet Elijbet changed the title Add coverage for date-picker styles for when there is an active range selection. Add snapshot coverage for date-picker styles for when there is an active range selection. Jan 20, 2023
@geospatialem geospatialem added the needs triage Planning workflow - pending design/dev review. label Jan 27, 2025
@jcfranco
Copy link
Member

I think this already covered by https://esri.github.io/calcite-design-system/?path=/story/components-controls-datepicker--range-highlighted-test-only. @Elijbet Can you confirm?

@Elijbet
Copy link
Contributor Author

Elijbet commented Feb 27, 2025

I think this already covered by https://esri.github.io/calcite-design-system/?path=/story/components-controls-datepicker--range-highlighted-test-only. @Elijbet Can you confirm?

Yep. Looks like it is. We can close this.

@jcfranco
Copy link
Member

Thanks for checking. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.
Projects
None yet
Development

No branches or pull requests

4 participants