Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value List (Advanced Panel) - Avoid improper nesting of form elements and links - (2036570518) #5635

Closed
Tracked by #4599
dqateam opened this issue Oct 25, 2022 · 3 comments
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.

Comments

@dqateam
Copy link
Collaborator

dqateam commented Oct 25, 2022

Module:

42 Calcite Panel

Violation:

Avoid improper nesting of form elements and links

image

WCAG Reference:

Instance ID:

2036570518

Severity:

7

Description:

[Issue]
There are show/hide setting image controls without appropriate state information.

[User Impact]
Screen reader users will be unable to determine that these controls expand and collapse content. They will also have difficulty determining whether a control is currently expanded or collapsed.

[Code Reference]

<button aria-busy="false" aria-disabled="false" aria-label="Settings for events" class="button">
 (...)
</button>

Note:

[Suggestion]
Ensure custom controls provide proper textual name, role, and state information.

For show/hide controls, the following information is expected:

  • The element that shows and hides a content area must be a <button>.
  • When the content area is visible, the button must have aria-expanded="true". Otherwise, the button must have aria-expanded="false".
  • The button must have an accessible name set with internal text, aria-label, or aria-labelledby.

[Compliant Code Example]

<button aria-expanded="true" aria-busy="false" aria-disabled="false" aria-label="Settings for events" class="button">
 (...)
</button>

Media Type:

Forms

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Oct 25, 2022
@geospatialem
Copy link
Member

geospatialem commented Oct 26, 2022

While the error surfaces in panel, is related to the calcite-value-list component per the sample, and could be a result of the configuration (see: html code).

@geospatialem geospatialem changed the title Calcite Panel - Avoid improper nesting of form elements and links - (2036570518) Value List (Advanced Panel) - Avoid improper nesting of form elements and links - (2036570518) Nov 17, 2022
@driskull
Copy link
Member

I think this would be a user configuration solution

@geospatialem
Copy link
Member

Agreed - closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants