Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Time Picker with Label (Accordion Complex) - Provide a valid label for form fields - (2036570513) #5632

Closed
Tracked by #4599
dqateam opened this issue Oct 25, 2022 · 4 comments
Assignees
Labels
1 - assigned Issues that are assigned to a sprint and a team member. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. research Issues that require more in-depth research or multiple team members to resolve or make decision.

Comments

@dqateam
Copy link
Collaborator

dqateam commented Oct 25, 2022

Module:

41 Accordion Complex

Violation:

Provide a valid label for form fields

image

WCAG Reference:

Instance ID:

2036570513

Severity:

10

Description:

[Issue]
There are buttons without accessible names. Examples include:

[User Impact]
Screen reader users will be unable to determine the purpose of these buttons. Speech input users will have difficulty activating them.

Test on https://geospatialem.github.io/calcite-samples/2-accordion

[Code Reference]

<div aria-controls="input-time-picker-9b295556-ebec-48e7-92c9-fd20abceba4b-popover" aria-haspopup="dialog" aria-owns="input-time-picker-9b295556-ebec-48e7-92c9-fd20abceba4b-popover" id="input-time-picker-9b295556-ebec-48e7-92c9-fd20abceba4b" role="combobox" aria-expanded="false">
 (...)
</div>

Note:

[Suggestion]
Provide a valid label for form fields. This includes providing accessible names for buttons. The accessible name of a button can be set with internal text, an aria-label attribute, or an aria-labelledby attribute. Good accessible names are both concise and descriptive.

[Compliant Code Example]

<div aria-label="Time of Day" aria-controls="input-time-picker-9b295556-ebec-48e7-92c9-fd20abceba4b-popover" aria-haspopup="dialog" aria-owns="input-time-picker-9b295556-ebec-48e7-92c9-fd20abceba4b-popover" id="input-time-picker-9b295556-ebec-48e7-92c9-fd20abceba4b" role="combobox" aria-expanded="false">
 (...)
</div>

Media Type:

Forms

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Oct 25, 2022
@geospatialem geospatialem changed the title Accordion Complex - Provide a valid label for form fields - (2036570513) Input Time Picker (Accordion Complex) - Provide a valid label for form fields - (2036570513) Nov 17, 2022
@geospatialem
Copy link
Member

Can we add a label prop to the component for additional context?

@geospatialem geospatialem added the research Issues that require more in-depth research or multiple team members to resolve or make decision. label Feb 13, 2023
@geospatialem geospatialem changed the title Input Time Picker (Accordion Complex) - Provide a valid label for form fields - (2036570513) Input Time Picker with Label (Accordion Complex) - Provide a valid label for form fields - (2036570513) Feb 27, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Feb 27, 2023
@geospatialem
Copy link
Member

#6500 might have a similar solution - specific to select, slider, and combobox

@brittneytewks
Copy link

Research needs to determine estimate and priority

@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Mar 30, 2023
@geospatialem
Copy link
Member

This is not valid - the buttons have accessible names, and are not accessible to AT as a tabindex of -1 is set for all, and AT users can use the arrow keys or numerical keys to change the value. Closing out the issue as context is provided, and it is a false positive of the accessibility audit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. research Issues that require more in-depth research or multiple team members to resolve or make decision.
Projects
None yet
Development

No branches or pull requests

4 participants