Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip: adjust default padding across scale property and pointerDisabled with the ability to disable the pointer #5334

Open
3 tasks
COV-GIS opened this issue Sep 16, 2022 · 8 comments
Labels
0 - new New issues that need assignment. ArcGIS Mission Issues logged by ArcGIS Mission team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - sm Small design effort; 1-4 days of design work estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.

Comments

@COV-GIS
Copy link

COV-GIS commented Sep 16, 2022

Description

Tooltip with half the padding and possibly slightly smaller font size.

Acceptance Criteria

Add boolean compact (or similar) property to accomplish the above.

Also...possibly a property to disable the arrow element. When combined with compact, toolitp would be more like a native browser title.

Relevant Info

No response

Which Component

tooltip

Example Use Case

For actions in bars or pads or in header slots the tooltip size is fine as is. But seems too big and overwhelming in content with lots of controls and such, especially when using small scale components.

A smaller tooltip without an arrow might also be able to replace native expand/collapse titles for blocks and accordions, and other similar situations. I don't know if that would create an accessibility issue or not. A mix of tooltips and native titles seems visually odd in my personal opinion.

Calcite design solution

Figma file available and includes:

  • Added scales
  • Reduced padding on medium scale when compared to current Tooltip
  • Added pointer-disabled property

image

@COV-GIS COV-GIS added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Sep 16, 2022
@ashetland
Copy link
Contributor

A compact version of tooltip makes a lot of sense. I'd suggest disable-pointer could always be an option, not just on the compact version. The font size is already at 12, the standard for scale="s". Here's a quick mock with padding reduced to 8, 4px. Not sure the 10px font size is big enough.
CleanShot 2022-09-20 at 09 02 25@2x

@macandcheese
Copy link
Contributor

Yes, disable-pointer shouldn't be limited to a single scale. I think using the s, m, l scale instead of default / compact makes sense. We use 10px on s input-message, so maybe worth evaluating that as well.

@ashetland
Copy link
Contributor

Agree on a full scale set of s, m, l. Here's a Chrome tip with our 10px-font tooltip overlaid. Might be worth going to 11px to increase readability.
CleanShot 2022-09-22 at 14 22 31@2x

@geospatialem geospatialem added design Issues that need design consultation prior to development. p - low Issue is non core or affecting less that 10% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. labels Dec 18, 2023
@geospatialem geospatialem changed the title Tooltip: compact Tooltip: adjust default padding across scale property and pointerDisabled with the ability to disable the pointer Dec 18, 2023
@jul11557
Copy link

+1 on this for ArcGIS Mission. We have no issues with the font size at 12, but would appreciate the option for smaller padding so that the tooltip doesn't block other UI elements.

@geospatialem geospatialem added the ArcGIS Mission Issues logged by ArcGIS Mission team members. label Feb 13, 2024
@ashetland ashetland added the estimate - design - sm Small design effort; 1-4 days of design work label Feb 13, 2024
@macandcheese
Copy link
Contributor

To confirm from design, we plan to maintain the font size and reduce the default padding across the board, correct? @ashetland @SkyeSeitz

@ashetland
Copy link
Contributor

Correct

@ashetland ashetland self-assigned this Apr 16, 2024
@ashetland
Copy link
Contributor

ashetland commented Apr 29, 2024

Updated designs posted in the issue description.

@ashetland ashetland added the ready for dev Issues ready for development implementation. label Apr 29, 2024
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 29, 2024
Copy link
Contributor

cc @geospatialem, @brittneytewks

@ashetland ashetland removed the needs triage Planning workflow - pending design/dev review. label Apr 29, 2024
@geospatialem geospatialem added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. label Sep 6, 2024
@geospatialem geospatialem added this to the 2025-01-28 - Jan Release milestone Sep 6, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 6, 2024
@geospatialem geospatialem added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Feb 24, 2025
@DitwanP DitwanP removed this from the 2025-03-25 - 3.1.0 Mar Release milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Mission Issues logged by ArcGIS Mission team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - sm Small design effort; 1-4 days of design work estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Development

No branches or pull requests

7 participants