Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Action] Evaluate need to provide an alternative style for active state #5003

Open
3 tasks
geospatialem opened this issue Jul 22, 2022 · 3 comments
Open
3 tasks
Labels
0 - new New issues that need assignment. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. p - low Issue is non core or affecting less that 10% of people using the library research Issues that require more in-depth research or multiple team members to resolve or make decision.

Comments

@geospatialem
Copy link
Member

geospatialem commented Jul 22, 2022

Description

One of three issues stemmed from #4813.

Determine if there is a need for differing styles to further emphasize an active state. Currently a light gray state is provided in light mode, and dark gray for dark mode. Could additional context be provided to users?

example-with-action-1
example-with-action-2

Acceptance Criteria

  • Research active state vs other states in the action component, and possibly across components
  • Provide design recommendations for an active state across components
  • Implement an alternative style for the active state across components

Relevant Info

This issue surfaced from discussion of the action component, which has a similar appearance when in an active state that is depicted on the :focus/:active/:hover states.

So it isn't clear if the active state is true, or not when focused. While the indicator attribute can be used alongside, there should be more visual prominence that the action is in an :active state.

cc @macandcheese

Which Component

Specifically with action, but could impact other components.

Example Use Case

Example with action: https://codepen.io/geospatialem/pen/QWmWdoQ.

@geospatialem geospatialem added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. research Issues that require more in-depth research or multiple team members to resolve or make decision. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 22, 2022
@macandcheese
Copy link
Contributor

Note: explore if a "subtle" and "loud" (... with better names) could work, or if a single state such as the bordered example above is best. Note that users can always customize both the indicator and the action active state through css vars, so that may be a justification for a single one)...

@webmapLee
Copy link

const action = document.querySelector('calcite-action').shadowRoot
action.querySelector('.button').setAttribute('style','padding:0.5em;')

is it can help?

@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library and removed airtable labels May 25, 2023
@geospatialem geospatialem added this to the Design Backlog milestone Jun 1, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jul 6, 2023
@ashetland
Copy link
Contributor

Also to explore: using foreground-current for the active state

@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@macandcheese macandcheese changed the title Evaluate need to provide an alternative style for active state [Action] Evaluate need to provide an alternative style for active state Sep 20, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. p - low Issue is non core or affecting less that 10% of people using the library research Issues that require more in-depth research or multiple team members to resolve or make decision.
Projects
None yet
Development

No branches or pull requests

6 participants