Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor e2e tests to use page.setContent #4844

Open
eriklharper opened this issue Jul 5, 2022 · 0 comments
Open

Refactor e2e tests to use page.setContent #4844

eriklharper opened this issue Jul 5, 2022 · 0 comments
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.

Comments

@eriklharper
Copy link
Contributor

eriklharper commented Jul 5, 2022 •
edited by jcfranco
Loading

Test type

e2e

Which Component(s)

all

Unstable Tests

n/a

Test error, if applicable

No response

PR skipped, if applicable

Additional Info

Since page.setContent implicitly calls page.waitForChanges we should use this everywhere in place of setting the html directly in the newE2EPage() constructor function. A codemod could be used to streamline updates.

Further usage of newE2EPage({ html }) should be prevented via linting rules.
@eriklharper eriklharper added testing Issues related to automated or manual testing. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. labels Jul 5, 2022
@jcfranco jcfranco removed the p - high Issue should be addressed in the current milestone, impacts component or core functionality label Nov 20, 2022
@benelan benelan added the Calcite (dev) Issues logged by Calcite developers. label Jan 30, 2023
@jcfranco jcfranco mentioned this issue Aug 17, 2023
Closed
@geospatialem geospatialem added the needs triage Planning workflow - pending design/dev review. label Jan 27, 2025
@jcfranco jcfranco added p - low Issue is non core or affecting less that 10% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. estimate - 5 A few days of work, definitely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. estimate - 3 A day or two of work, likely requires updates to tests. labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jcfranco @eriklharper @alisonailea @geospatialem @benelan