Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Block loading state when not open #3075

Closed
asangma opened this issue Sep 20, 2021 · 2 comments
Closed

Enhancement: Block loading state when not open #3075

asangma opened this issue Sep 20, 2021 · 2 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request.

Comments

@asangma
Copy link
Contributor

asangma commented Sep 20, 2021

Description

Add a way to see if Block is loading when its not open.

Acceptance Criteria

  • Design should use existing slots

Relevant Info

Which Component

Block

Example Use Case

Have a consistent design for a Block that is in a loading state but is not open.

Proposed design

image

  • Use the same slot that other statuses use.
  • Loading indicator rotates
  • If Block has loading prop, status is ignored.
@asangma asangma added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 20, 2021
@julio8a julio8a removed the needs triage Planning workflow - pending design/dev review. label Sep 24, 2021
@julio8a julio8a added this to the Sprint 9/27 – 10/8 milestone Sep 24, 2021
@anveshmekala anveshmekala self-assigned this Oct 5, 2021
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Oct 5, 2021
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 13, 2021
@github-actions github-actions bot assigned benelan and unassigned anveshmekala Oct 13, 2021
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@benelan
Copy link
Member

benelan commented Nov 1, 2021

@benelan benelan closed this as completed Nov 1, 2021
@benelan benelan added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request.
Projects
None yet
Development

No branches or pull requests

5 participants