Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common test helper for early ref removal #11620

Open
jcfranco opened this issue Feb 25, 2025 · 0 comments
Open

Add common test helper for early ref removal #11620

jcfranco opened this issue Feb 25, 2025 · 0 comments
Labels
0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library research Issues that require more in-depth research or multiple team members to resolve or make decision. resolution: refine For issues we support, but additional details are needed prior to dev work. tooling Issues relating to build system fixes or improvements.

Comments

@jcfranco
Copy link
Member

Priority impact

p - low

Summary

We need a test helper to add coverage for use cases where an element might be removed from the DOM to ensure the ref is available when ref-related logic runs.

Desired Outcome

A common test helper that creates and configures a component, then removes it to ensure code that runs after any refs are cleared doesn't throw.

Things to consider:

  • certain ref callbacks are invoked in certain configurations, so the helper might need to handle different scenarios
  • the test util will likely need to handle the component in the browser context as async Puppeteer API calls might give extra time that hides potential errors

Resources

No response

@jcfranco jcfranco added 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. research Issues that require more in-depth research or multiple team members to resolve or make decision. resolution: refine For issues we support, but additional details are needed prior to dev work. tooling Issues relating to build system fixes or improvements. labels Feb 25, 2025
@github-actions github-actions bot added the p - low Issue is non core or affecting less that 10% of people using the library label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library research Issues that require more in-depth research or multiple team members to resolve or make decision. resolution: refine For issues we support, but additional details are needed prior to dev work. tooling Issues relating to build system fixes or improvements.
Projects
None yet
Development

No branches or pull requests

1 participant