Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BlockGroup, List]: canPull, canPut should be called for moving via keyboard as well #11447

Open
2 of 6 tasks
driskull opened this issue Feb 4, 2025 · 0 comments
Open
2 of 6 tasks
Assignees
Labels
1 - assigned Issues that are assigned to a sprint and a team member. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library

Comments

@driskull
Copy link
Member

driskull commented Feb 4, 2025

Check existing issues

Actual Behavior

canPull and canPut are not called when moving via keyboard from one list to another.

Expected Behavior

[BlockGroup, List]: canPull, canPut should be called for moving via keyboard as well

Reproduction Sample

https://codepen.io/Matt-Driscoll/pen/wBwbZgp?editors=1010

Reproduction Steps

  1. open the codepen
  2. try to drag a item to another group via mouse
  3. notice it doesn't work
  4. try to move an item to another group via keyboard
  5. notice it works

Reproduction Version

3.0.0-next.127

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

N/A

@driskull driskull added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Feb 4, 2025
@github-actions github-actions bot added the impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone label Feb 4, 2025
@DitwanP DitwanP added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. 1 - assigned Issues that are assigned to a sprint and a team member. and removed needs triage Planning workflow - pending design/dev review. 0 - new New issues that need assignment. labels Feb 18, 2025
@DitwanP DitwanP added this to the 2025-02-25 - Feb Milestone milestone Feb 18, 2025
@DitwanP DitwanP added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Feb 18, 2025
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests

3 participants