Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dialog] overflow: hidden gets removed when closing dialog even if another dialog is still opened #11408

Open
2 of 6 tasks
rpanichakit9541 opened this issue Jan 30, 2025 · 1 comment
Open
2 of 6 tasks

[dialog] overflow: hidden gets removed when closing dialog even if another dialog is still opened #11408

rpanichakit9541 opened this issue Jan 30, 2025 · 1 comment
Labels
0 - new New issues that need assignment. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2025-05-13 - 3.2....

Comments

@rpanichakit9541
Copy link
Contributor

rpanichakit9541 commented Jan 30, 2025 •
edited by jcfranco
Loading

Check existing issues

Actual Behavior

If there are two dialogs opened, when you close the first one it immediately removes overflow: hidden from the <html> tag even though another dialog is still opened.

Expected Behavior

overflow: hidden should remain on <html> tag if there's still an opened dialog

Reproduction Sample

https://codepen.io/rpanichakit/pen/VYZgRrm?editors=1000

Reproduction Steps

  1. Open the codepen URL
  2. Inspect the HTML to see the overflow: hidden present on the <html> tag inside the iframe in codepen
  3. Close the dialog, and inspect again to see overflow: hidden is now removed, even though another dialog is still opened.

Reproduction Version

2.13.2

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

https://devtopia.esri.com/WebGIS/arcgis-metadata-editor/issues/1536

This happens in a real workflow when the main workflow is inside a dialog and then from that UI, the user can trigger another dialog like confirmation of an action.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@rpanichakit9541 rpanichakit9541 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Jan 30, 2025
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jan 30, 2025
@jcfranco
Copy link
Member

It looks like dialog needs to check the total open dialogs here before deciding to remove the util class (similar to modal).

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jan 31, 2025
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2025-05-13 - 3.2.0 May Main Release
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @rpanichakit9541 @DitwanP