Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use localization patterns for trailing periods #10890

Closed
2 of 6 tasks
geospatialem opened this issue Nov 26, 2024 · 5 comments
Closed
2 of 6 tasks

Use localization patterns for trailing periods #10890

geospatialem opened this issue Nov 26, 2024 · 5 comments
Assignees
Labels
1 - assigned Issues that are assigned to a sprint and a team member. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. i18n-l10n issues dealing with internationalization/localization impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive

Comments

@geospatialem
Copy link
Member

Check existing issues

Actual Behavior

Remaining effort from #7708 for hardcoded strings WRT trailing periods should be pulled into t9n bundles or use a formatting utility.

{this.numbered ? <div class="stepper-item-number">{this.renderNumbers()}.</div> : null}

Expected Behavior

Coming soon, ultimately avoid hardcoded strings

cc @jcfranco @annierm18

Reproduction Sample

https://codepen.io/jcfranco/pen/RwEpwbL?editors=100

Reproduction Steps

  1. Open codepen
  2. Look at console to see the hardcoded assistive text

Note that the sample is specific to one component, the descriptive hardcoded values are depicted in the summary above.

Reproduction Version

1.8.0

Relevant Info

#7708

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)

@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. i18n-l10n issues dealing with internationalization/localization labels Nov 26, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Nov 26, 2024
@macandcheese
Copy link
Contributor

Specifically for Stepper Item - we may be able to re-design this to avoid this period altogether - AFAIK it is only stylistic - we can probably do a small adjustment and place the localized number in an avatar or other UI. cc @SkyeSeitz @ashetland

@jcfranco jcfranco self-assigned this Nov 26, 2024
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Nov 26, 2024
@jcfranco
Copy link
Member

@macandcheese That would be great!

@geospatialem geospatialem added estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Nov 26, 2024
@macandcheese
Copy link
Contributor

macandcheese commented Nov 26, 2024

Breakout issue: #10893

@annierm18
Copy link
Contributor

Response from the Translation team:

"Now we see how they structure it, it should be fine to hard code it. Please make sure to test Arabic and Hebrew closely to check the order is correct."

In summary, it is okay to hardcode the trailing period in this instance. This means the "." string does not need to be put in the translation bundles. Just make sure to test with RTL languages.

@jcfranco
Copy link
Member

jcfranco commented Dec 4, 2024

Based on ☝️, we can close this one. Thanks, @annierm18!

@jcfranco jcfranco closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. i18n-l10n issues dealing with internationalization/localization impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Projects
None yet
Development

No branches or pull requests

4 participants