Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update components to account for new v4.0 calcite-action design #10777

Open
2 of 23 tasks
DitwanP opened this issue Nov 18, 2024 · 1 comment
Open
2 of 23 tasks

Update components to account for new v4.0 calcite-action design #10777

DitwanP opened this issue Nov 18, 2024 · 1 comment
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.

Comments

@DitwanP
Copy link
Contributor

DitwanP commented Nov 18, 2024 •
edited by ashetland
Loading

Check existing issues

Description

The changes to Actions from issue #10759 necessitate updates to any components that use Actions. Outlined below on a per-component basis:

  • Updated Actions spacing
  • Updated action-slot spacing
  • Updated close buttons
  • Updated clear buttons
  • Actions should no longer stretch to fill the height of their container

Overview example using a representative set of components showing updated spacing and improved alignment:
Image

Acceptance Criteria

Relevant Info

Part of 4.0's Phase 2

Blocked by: #10759

Which Component

See above.

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@DitwanP DitwanP added enhancement Issues tied to a new feature or request. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. blocked This issue is blocked by another issue. estimate - 5 A few days of work, definitely requires updates to tests. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. labels Nov 18, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Nov 18, 2024
@DitwanP DitwanP mentioned this issue Nov 18, 2024
Open
20 tasks
@ashetland ashetland added the design Issues that need design consultation prior to development. label Jan 6, 2025
@ashetland ashetland self-assigned this Feb 20, 2025
@ashetland ashetland added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Feb 20, 2025
@ashetland ashetland changed the title [Action slots] update sizing and spacing for slotted actions for 4.0 (Feb) Update components to account for new calcite-action design Feb 26, 2025
This was referenced Feb 26, 2025
Closed
Closed
@ashetland ashetland added the ready for dev Issues ready for development implementation. label Feb 26, 2025
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@ashetland ashetland changed the title Update components to account for new calcite-action design Update components to account for new v4.0 calcite-action design Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DitwanP @ashetland