Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tokens] Add foreground.highlight for 4.0 #10756

Open
3 of 8 tasks
geospatialem opened this issue Nov 18, 2024 · 1 comment
Open
3 of 8 tasks

[Tokens] Add foreground.highlight for 4.0 #10756

geospatialem opened this issue Nov 18, 2024 · 1 comment
Labels
0 - new New issues that need assignment. breaking change Issues and pull requests with code changes that are not backwards compatible. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.

Comments

@geospatialem
Copy link
Member

geospatialem commented Nov 18, 2024 •
edited by SkyeSeitz
Loading

Check existing issues

Description

Enhance tokens for component selections across the design system for light and dark mode colors.

Acceptance Criteria

In core/color.json:

  • Adjust h-bb-010 to D6EFFF

In semantic/color.json:

  • deprecate “foreground.current”
  • create new “foreground.highlight” token
  • light-mode: h-bb-10
  • dark-mode: m-bb-090

🔗 Figma Specs

Image
Image
Image

Relevant Info

Part of 4.0's Phase II - Selection

Which Component

Tokens

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. breaking change Issues and pull requests with code changes that are not backwards compatible. 0 - new New issues that need assignment. blocked This issue is blocked by another issue. needs triage Planning workflow - pending design/dev review. design-tokens Issues requiring design tokens. labels Nov 18, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Nov 18, 2024
@geospatialem geospatialem mentioned this issue Nov 18, 2024
Open
5 tasks
@geospatialem geospatialem added the design Issues that need design consultation prior to development. label Nov 18, 2024
@ashetland ashetland removed the needs triage Planning workflow - pending design/dev review. label Dec 19, 2024
@ashetland ashetland added the p - high Issue should be addressed in the current milestone, impacts component or core functionality label Dec 31, 2024
@ashetland ashetland added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jan 6, 2025
@ashetland ashetland mentioned this issue Jan 24, 2025
Open
8 tasks
@ashetland ashetland removed the blocked This issue is blocked by another issue. label Feb 7, 2025
@SkyeSeitz SkyeSeitz added the ready for dev Issues ready for development implementation. label Feb 21, 2025
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. breaking change Issues and pull requests with code changes that are not backwards compatible. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@geospatialem @SkyeSeitz @ashetland