Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Token] Update light-mode border colors for 4.0 #10755

Open
3 of 8 tasks
geospatialem opened this issue Nov 18, 2024 · 1 comment
Open
3 of 8 tasks

[Token] Update light-mode border colors for 4.0 #10755

geospatialem opened this issue Nov 18, 2024 · 1 comment
Labels
0 - new New issues that need assignment. breaking change Issues and pull requests with code changes that are not backwards compatible. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.

Comments

@geospatialem
Copy link
Member

geospatialem commented Nov 18, 2024

Check existing issues

Description

Update values of semantic tokens border color tokens.

Blocked issues: #10769

🔗 Figma Specs: https://www.figma.com/design/i2p9r2mzxWqQmEW6Ya9nwg/%5BToken%5D-Update-border-colors-for-4.0?node-id=4501-714&m=dev

Image

Acceptance Criteria

Light mode border colors updated:

  • border.1=core.neutral.blk.040
  • border.2=core.neutral.blk.030
  • border.3=core.neutral.blk.020

Relevant Info

Part of 4.0's Phase I - Colors

Which Component

Tokens

Example Use Case

Refer to relevant info above.

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

@geospatialem geospatialem added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. breaking change Issues and pull requests with code changes that are not backwards compatible. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. estimate - 3 A day or two of work, likely requires updates to tests. design-tokens Issues requiring design tokens. labels Nov 18, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Nov 18, 2024
@geospatialem geospatialem added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. label Nov 18, 2024
@ashetland ashetland added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jan 6, 2025
@ashetland ashetland changed the title [Token] Update border colors for 4.0 [Token] Update light-mode border colors for 4.0 Feb 7, 2025
@ashetland ashetland added the ready for dev Issues ready for development implementation. label Feb 7, 2025
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

cc @geospatialem, @brittneytewks

@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. breaking change Issues and pull requests with code changes that are not backwards compatible. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Development

No branches or pull requests

4 participants