Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reveal action to calcite-input with type "password" #10730

Open
2 of 5 tasks
ethanbdev opened this issue Nov 14, 2024 · 1 comment
Open
2 of 5 tasks

Add a reveal action to calcite-input with type "password" #10730

ethanbdev opened this issue Nov 14, 2024 · 1 comment
Labels
0 - new New issues that need assignment. ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library

Comments

@ethanbdev
Copy link
Contributor

Check existing issues

Description

We have a requirement for a UI that reveals hidden text in a calcite input. It would be really handy if the design system handled this, giving us an opt-in reveal action for a password input type.

Acceptance Criteria

When input is type password, we can opt-in to a reveal action that shows the actual text instead of the hidden text. We would want this to work in all major browsers.

Relevant Info

Some browsers already implement this with the native password input (like edge):
2024-11-14_12-29-50 (1)

There is also an issue for this in the html spec:
whatwg/html#7293

Edge also adds the reveal to the calcite input, but it would be great to align the design across browsers for our users.

Which Component

calcite-input

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Web Analysis

@ethanbdev ethanbdev added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Nov 14, 2024
@github-actions github-actions bot added ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Nov 14, 2024
@macandcheese
Copy link
Contributor

I think this is a great enhancement and one that could justify a standalone calcite-input-password component to align with our newer components like calcite-input-text, calcite-input-number, etc.

@driskull driskull added p - low Issue is non core or affecting less that 10% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. labels Feb 25, 2025
@DitwanP DitwanP added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Development

No branches or pull requests

4 participants