Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden or disabled dropdown items in list actions confuse keyboard navigation #10584

Open
2 of 6 tasks
nwhittaker opened this issue Oct 22, 2024 · 1 comment
Open
2 of 6 tasks

Hidden or disabled dropdown items in list actions confuse keyboard navigation #10584

nwhittaker opened this issue Oct 22, 2024 · 1 comment
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.
Milestone
Stalled

Comments

@nwhittaker
Copy link
Contributor

Check existing issues

Actual Behavior

Give a list of items with dropdowns slotted in actions-end and after setting focus on the dropdown's slotted trigger action:

Description Screenshot
Pressing ArrowDown opens dropdown but, if first dropdown item is hidden, focus shifts to next list items's dropdown trigger. Screenshot 2024-10-22 at 5 09 56 PM
Pressing ArrowUp opens dropdown but, if last dropdown item is hidden, focus shifts to previous list item's dropdown trigger. Screenshot 2024-10-22 at 5 09 42 PM
Pressing ArrowDown opens dropdown but, if first dropdown item is disabled, focus shifts to the disabled item. Screenshot 2024-10-22 at 5 36 09 PM
Pressing ArrowUp opens dropdown but, if last dropdown item is disabled, focus shift to the disabled item. Screenshot 2024-10-22 at 5 36 26 PM

Expected Behavior

Give a list of items with dropdowns slotted in actions-end and after setting focus on the dropdown's slotted trigger action:

Description Screenshot
Pressing ArrowDown opens dropdown and focus shifts to first visible, non-disabled dropdown item. Screenshot 2024-10-22 at 5 41 14 PM
Pressing ArrowUp opens dropdown and focus shifts to last visible, non-disabled dropdown item. Screenshot 2024-10-22 at 5 41 01 PM

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/JjgrOPQ

Reproduction Steps

  1. Visit the sample
  2. Click the first list-item's action twice and then press the down arrow key
  3. Click the second list-item's action twice and then press the up arrow key
  4. Click the third list-item's action twice and then press the down arrow key
  5. Click the fourth list-item's action twice and then press the up arrow key

Reproduction Version

2.13.1

Relevant Info

Possible related to #8205.

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

Impact towards usability and accessibility:

  1. Dropdowns shouldn't open without also trapping focus
  2. Disabled dropdown items shouldn't be able to gain focus

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Field Apps
@nwhittaker nwhittaker added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Oct 22, 2024
@github-actions github-actions bot added ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Oct 22, 2024
@nwhittaker nwhittaker changed the title Hidden/disabled dropdown items in list actions confuse keyboard navigation Hidden or disabled dropdown items in list actions confuse keyboard navigation Oct 22, 2024
@jcfranco
Copy link
Member

jcfranco commented Nov 5, 2024

This might be addressed by #8623.

@geospatialem geospatialem added blocked This issue is blocked by another issue. and removed blocked This issue is blocked by another issue. labels Nov 12, 2024
@geospatialem geospatialem added this to the Stalled milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.
Projects
None yet
Milestone
Stalled
Development

No branches or pull requests
3 participants
@jcfranco @nwhittaker @geospatialem