Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow themed to specify token target for inherited, internal CSS props #10569

Open
jcfranco opened this issue Oct 21, 2024 · 0 comments
Open
Labels
0 - new New issues that need assignment. estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.

Comments

@jcfranco
Copy link
Member

Priority impact

p - low

Summary

Components that inherit internal component props for reused styles (e.g., https://github.com/Esri/calcite-design-system/pull/10532/files), need to define CSS props on a different element (e.g., parent tabs instead of tab-title).

themed should introduce a new prop to target a different element to apply the parent props to.

The current, brittle, work around is to provide internal CSS props as input to themed.

Desired Outcome

A new prop for TestSelectToken to specify a different style target than the component under test.

Resources

No response

@jcfranco jcfranco added tooling Issues relating to build system fixes or improvements. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 21, 2024
@github-actions github-actions bot added the p - low Issue is non core or affecting less that 10% of people using the library label Oct 21, 2024
@macandcheese macandcheese added the estimate - 5 A few days of work, definitely requires updates to tests. label Feb 25, 2025
@DitwanP DitwanP added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Projects
None yet
Development

No branches or pull requests

3 participants