Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[combobox-item] refactor logic to get ancestor elements. #10459

Open
1 of 5 tasks
driskull opened this issue Sep 30, 2024 · 0 comments
Open
1 of 5 tasks

[combobox-item] refactor logic to get ancestor elements. #10459

driskull opened this issue Sep 30, 2024 · 0 comments
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.

Comments

@driskull
Copy link
Member

Description

Code in question:

this.ancestors = getAncestors(this.el);

This should be refactored and moved to the calcite-combobox element.

Proposed Advantages

if grandparent is removed, I think this would get stale and incorrect.

I don't think it would update because connectedCallback of a grandparent wouldn't trigger anything here.

Which Component

calcite-combobox-item

Relevant Info

#10450 (comment)

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@driskull driskull added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 30, 2024
@driskull driskull mentioned this issue Sep 30, 2024
Merged
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Sep 30, 2024
@macandcheese macandcheese added estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library labels Feb 25, 2025
@DitwanP DitwanP added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@driskull @macandcheese @DitwanP