Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popover, Tooltip] Support one to many relationship #10401

Open
2 of 6 tasks
driskull opened this issue Sep 26, 2024 · 2 comments
Open
2 of 6 tasks

[Popover, Tooltip] Support one to many relationship #10401

driskull opened this issue Sep 26, 2024 · 2 comments
Assignees
Labels
1 - assigned Issues that are assigned to a sprint and a team member. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.

Comments

@driskull
Copy link
Member

driskull commented Sep 26, 2024

Check existing issues

Description

Allow an array of reference elements to support a single tooltip or popover being associated with multiple elements.

This would handle the use case where a single tooltip is applicable to multiple reference elements. In the Maps SDK, we have a use case where each layer type has an icon and that icon has a tooltip. Currently, to achieve this, each icon needs its own tooltip even though there are only a few different tooltips.

Enhance tooltip and popover to support referenceElement: HTMLElement | HTMLElement[]

Currently, if you have a lot of icons where you want the same tooltip to appear on hover, you have to create the same number of identical tooltips.

Acceptance Criteria

referenceElement property is enhanced to support an array

Relevant Info

No response

Which Component

popover, tooltip

Example Use Case

tooltip.referenceElement = [iconEl, iconEl, iconEl, "my-el-id"];

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript

@driskull driskull added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 26, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Sep 26, 2024
@driskull driskull changed the title [Popover, Tooltip] Support one to many relationship for referenceElement. [Popover, Tooltip] Support one to many relationship Sep 26, 2024
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Sep 26, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Sep 26, 2024
@driskull
Copy link
Member Author

driskull commented Dec 5, 2024

@geospatialem I think we may need to backlog this one.

The problem I'm running into is that floatingUI doesn't have a way to watch multiple reference elements and position an element according to them. There's really know way to know which reference element would be the active one to use for positioning.

This would be a bigger refactor than I had initially thought.

@geospatialem geospatialem added the spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. label Dec 5, 2024
@geospatialem
Copy link
Member

I think we may need to backlog this one.

The problem I'm running into is that floatingUI doesn't have a way to watch multiple reference elements and position an element according to them. There's really know way to know which reference element would be the active one to use for positioning.

This would be a bigger refactor than I had initially thought.

Reallocated to early 2025 as a spike to determine next steps with trying to determine which reference element is active. 🏈

@geospatialem geospatialem added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Feb 24, 2025
@geospatialem geospatialem removed this from the 2025-03-25 - 3.1.0 Mar Release milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Projects
None yet
Development

No branches or pull requests

2 participants