Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Multiple components]: rename the overlayPositioning property for consistency and readability #10391

Open
1 of 5 tasks
DitwanP opened this issue Sep 25, 2024 · 0 comments
Open
1 of 5 tasks

[Multiple components]: rename the overlayPositioning property for consistency and readability #10391

DitwanP opened this issue Sep 25, 2024 · 0 comments
Labels
0 - new New issues that need assignment. breaking change Issues and pull requests with code changes that are not backwards compatible. calcite-components Issues specific to the @esri/calcite-components package. estimate - 8 Requires input from team, consider smaller steps. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.

Comments

@DitwanP
Copy link
Contributor

DitwanP commented Sep 25, 2024

Description

There are multiple components with the overlayPositioning property and the naming isn't very clear.

Comment from Matt on a similar issue:

We have quite a few components where we use the property name overlayPositioning and it is basically just for the calcite-action-menu.

Proposed Advantages

  • Consistency
  • Readability

Which Component

  • action-bar
  • action-group
  • action-menu
  • action-pad
  • block
  • combobox
  • dialog
  • dropdown
  • flow-item
  • input-date-picker
  • input-time-zone
  • panel
  • popover
  • split-button
  • tooltip

Maybe others if I missed any.

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@DitwanP DitwanP added refactor Issues tied to code that needs to be significantly reworked. breaking change Issues and pull requests with code changes that are not backwards compatible. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 25, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Sep 25, 2024
@DitwanP DitwanP mentioned this issue Sep 25, 2024
Merged
@macandcheese macandcheese added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 8 Requires input from team, consider smaller steps. labels Feb 25, 2025
@DitwanP DitwanP added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. breaking change Issues and pull requests with code changes that are not backwards compatible. calcite-components Issues specific to the @esri/calcite-components package. estimate - 8 Requires input from team, consider smaller steps. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@macandcheese @DitwanP