Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder text in all Inputs and Text Area does not pass AA #10361

Open
3 of 12 tasks
Tracked by #7180
ashetland opened this issue Sep 19, 2024 · 0 comments
Open
3 of 12 tasks
Tracked by #7180

Placeholder text in all Inputs and Text Area does not pass AA #10361

ashetland opened this issue Sep 19, 2024 · 0 comments
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design-tokens Issues requiring design tokens. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library

Comments

@ashetland
Copy link
Contributor

ashetland commented Sep 19, 2024

Check existing issues

Summary

Placeholder text should pass AA standards in both light and dark modes.

Actual Behavior

Our current placeholder text is #757575 in both light and dark modes. This passes against foreground.1 in light mode but not in dark mode.

Expected Behavior

Placeholder text should be assigned color.text.3 which passes AA in both color modes.

Reproduction Sample

https://codepen.io/ashetland/pen/bGPXOVa?editors=1000

Reproduction Steps

See the placeholder color not changing in dark mode.

Reproduction Version

v2.12

Working W3C Example/Tutorial

No response

Relevant Info

Components affected:

  • Input
  • Input Number
  • Input Text
  • Input Date Picker
  • Input Time Zone/Combobox
  • Text Area

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

@ashetland ashetland added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. a11y Issues related to Accessibility fixes or improvements. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Sep 19, 2024
@geospatialem geospatialem added the design-tokens Issues requiring design tokens. label Sep 19, 2024
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed p - high Issue should be addressed in the current milestone, impacts component or core functionality needs triage Planning workflow - pending design/dev review. labels Nov 5, 2024
@DitwanP DitwanP added this to the 2025-04-29 - Apr Milestone milestone Jan 3, 2025
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design-tokens Issues requiring design tokens. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests

3 participants