Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[block]: Remove E2E test when styles use reflected props #10084

Open
2 of 6 tasks
aPreciado88 opened this issue Aug 15, 2024 · 1 comment
Open
2 of 6 tasks

[block]: Remove E2E test when styles use reflected props #10084

aPreciado88 opened this issue Aug 15, 2024 · 1 comment
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library resolution: refine For issues we support, but additional details are needed prior to dev work.

Comments

@aPreciado88
Copy link
Contributor

Check existing issues

Description

Remove E2E test when checks that ensure styles use reflected props are added.

Acceptance Criteria

Remove E2E test

Relevant Info

No response

Which Component

block

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@aPreciado88 aPreciado88 added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 15, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Aug 15, 2024
@aPreciado88 aPreciado88 mentioned this issue Aug 15, 2024
Merged
@jcfranco jcfranco added estimate - 2 Small fix or update, may require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Feb 25, 2025
@jcfranco
Copy link
Member

@aPreciado88 Can you clarify which reflected prop styling this refers to? It’s not clear from the context.

On a related note, there's an issue with the reference test:

This line will always be null because header-icon is a custom class in the light DOM, so the piercing selector will never find it.

@jcfranco jcfranco added the resolution: refine For issues we support, but additional details are needed prior to dev work. label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library resolution: refine For issues we support, but additional details are needed prior to dev work.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcfranco @aPreciado88