Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[input, combobox, input-date-picker, input-number, input-text, input-time-picker, radio-button-group, segmented-control, select, text-area]: Simplify AT error messaging ids #10082

Open
1 of 5 tasks
aPreciado88 opened this issue Aug 15, 2024 · 0 comments
Open
1 of 5 tasks

[input, combobox, input-date-picker, input-number, input-text, input-time-picker, radio-button-group, segmented-control, select, text-area]: Simplify AT error messaging ids #10082

aPreciado88 opened this issue Aug 15, 2024 · 0 comments
Labels
0 - new New issues that need assignment. estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.

Comments

@aPreciado88
Copy link
Contributor

aPreciado88 commented Aug 15, 2024 •
edited
Loading

Description

  1. Define a common validation message ID (exported from Validation.tsx)
  2. Always assign the common ID Validation's input-message and optionally drop id from ValidationProps (could keep as optional to allow overrides if truly needed)
  3. Use the common ID in all aria-errormessage props

Proposed Advantages

Less id variable declarations.

Which Component

input, combobox, input-date-picker, input-number, input-text, input-time-picker, radio-button-group, segmented-control, select, text-area.

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@aPreciado88 aPreciado88 added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 15, 2024
@aPreciado88 aPreciado88 mentioned this issue Aug 15, 2024
Merged
@jcfranco jcfranco added estimate - 5 A few days of work, definitely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcfranco @aPreciado88